Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reactivity): unwrapped refs typing (fix #9314) #9343

Closed
wants to merge 1 commit into from

Conversation

OBe95
Copy link

@OBe95 OBe95 commented Oct 5, 2023

close #9314

Typing hints is suggesting to use .value for unwrapped objects' refs within a reactive array or a native collection

@pikax pikax added scope: types need test The PR has missing test cases. labels Oct 13, 2023
@pikax
Copy link
Member

pikax commented Oct 13, 2023

@OBe95 can you add some tests pls

@OBe95
Copy link
Author

OBe95 commented Oct 13, 2023

@pikax I just pushed some tests, let me know if you think of others

@sxzz
Copy link
Member

sxzz commented Oct 13, 2023

Duplicate of #8960

@sxzz sxzz marked this as a duplicate of #8960 Oct 13, 2023
@sxzz sxzz closed this Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need test The PR has missing test cases. scope: types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unwrapping of deep ref in Map is not correct
3 participants