Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(effect): tweak arguments #8947

Closed
wants to merge 2 commits into from

Conversation

Liberty-liu
Copy link

@Liberty-liu Liberty-liu commented Aug 10, 2023

The actual parameter dep passed to triggerEffects does not seem to have an array type.

@Liberty-liu Liberty-liu force-pushed the refactor/triggerEffects branch 3 times, most recently from 96fd380 to 140f6ae Compare August 11, 2023 01:03
@skirtles-code
Copy link
Contributor

Note for reviewers: I think there's some overlap with other PRs: #6185, #7827 and #8718.

@skirtles-code
Copy link
Contributor

I believe this section of the code was removed as part of #5912.

@edison1105 edison1105 closed this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Rejected
Development

Successfully merging this pull request may close these issues.

3 participants