-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(reactivity): fix shallowReactive map "unwraps" the nested refs #8502
Conversation
nice ! |
linking #8503 because it fix the same issue |
Size ReportBundles
Usages
|
CodSpeed Performance ReportMerging #8502 will degrade performances by 42.36%Comparing Summary
Benchmarks breakdown
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion, the changes proposed here are incorrect. The test expectations should not need to change for reactive()
collections.
I think the fix proposed in #8503 is closer to the desired behaviour.
fixed #8501
I found inconsistent behavior with Map.set in #8501, this is a breaking change, please close this PR if this is intentional