Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): remove defineProps optional properties #8486

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+10 −1
Open

fix(types): remove defineProps optional properties #8486

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
477be70
fix(types): remove `defineProps` optional properties
ItMaga Jun 2, 2023
84af6d1
chore: Merge branch 'main' into pr/8486
pikax Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(types): remove defineProps optional properties
@ItMaga
ItMaga committed Jun 2, 2023
commit 477be706d2854bb47ba13a9315f3c35bb9c92e2a
7 changes: 7 additions & 0 deletions packages/dts-test/setupHelpers.test-d.ts
View file
Original file line number Diff line number Diff line change
@@ -18,6 +18,7 @@ describe('defineProps w/ type declaration', () => {
// type declaration
const props = defineProps<{
foo: string
baz?: number
bool?: boolean
boolAndUndefined: boolean | undefined
}>()
@@ -26,6 +27,12 @@ describe('defineProps w/ type declaration', () => {
// @ts-expect-error
props.bar

expectType<{
foo: string
baz: number | undefined
bool: boolean
boolAndUndefined: boolean
}>(props)
expectType<boolean>(props.bool)
expectType<boolean>(props.boolAndUndefined)
})
5 changes: 3 additions & 2 deletions packages/runtime-core/src/apiSetupHelpers.ts
View file
Original file line number Diff line number Diff line change
@@ -4,7 +4,8 @@ import {
isFunction,
Prettify,
UnionToIntersection,
extend
extend,
LooseRequired
} from '@vue/shared'
import {
getCurrentInstance,
@@ -93,7 +94,7 @@ export function defineProps() {
return null as any
}

type DefineProps<T, BKeys extends keyof T> = Readonly<T> & {
type DefineProps<T, BKeys extends keyof T> = Readonly<LooseRequired<T>> & {
readonly [K in BKeys]-?: boolean
}