fix(compiler-sfc): props destructing default value type checking with unresolved type (#8326) #8340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inferred type at this point is
['null']and I don't think it can ever be theUNKNOWN_TYPEdue to the code herecore/packages/compiler-sfc/src/script/defineProps.ts
Line 210 in a374d7e
If it can be the
UNKNOWN_TYPEvia some other path, then I think would need to check for both. Null should be an allow any type so it shouldn't even bother trying to validate it default value here also,closes #8326