types(defineProps): remove optional properties from type #6421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for vuejs-coverage failed.
|
|
Maybe related: #6244 |
# Conflicts: # packages/runtime-core/src/apiSetupHelpers.ts # packages/shared/src/typeUtils.ts # test-dts/setupHelpers.test-d.ts
Size ReportBundles
Usages
|
sxzz
approved these changes
Oct 6, 2023
7 tasks
DrJume
added a commit
to DrJume/vuejs-core
that referenced
this pull request
Dec 5, 2023
…gn with type declaration * add tests for Extract*PropTypes ref: vuejs#6421
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6420
When we use
defineProps<{ a?:string}>it will create a type{ a?: string }which is not correct for the vuepropscontext, since if a property is declared the key will always be present, a more accurate representation of the type is{ a: string | undefined }, this PR does that.