Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compile-sfc): support Error type in defineProps #5955

Merged
merged 1 commit into from
Oct 30, 2023
Merged

fix(compile-sfc): support Error type in defineProps #5955

merged 1 commit into from
Oct 30, 2023

Conversation

zhmushan
Copy link
Contributor

reproduction

Obviously this list of types doesn't currently cover all Web APIs, and I also don't think "find one, add one" is a good way.

@sxzz
Copy link
Member

sxzz commented Oct 20, 2023

Could you please rebase your code?

@sxzz sxzz added 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. scope: script-setup wait changes labels Oct 20, 2023
@zhmushan zhmushan closed this Oct 20, 2023
@zhmushan zhmushan reopened this Oct 20, 2023
@github-actions
Copy link

github-actions bot commented Oct 20, 2023 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 86.5 kB 32.9 kB 29.7 kB
vue.global.prod.js 132 kB 49.6 kB 44.5 kB

Usages

Name Size Gzip Brotli
createApp 47.9 kB 18.9 kB 17.2 kB
createSSRApp 51.2 kB 20.2 kB 18.4 kB
defineCustomElement 50.3 kB 19.7 kB 17.9 kB
overall 61.3 kB 23.7 kB 21.6 kB

@zhmushan zhmushan force-pushed the define_error branch 3 times, most recently from 294b9a8 to f489944 Compare October 20, 2023 02:22
@zhmushan
Copy link
Contributor Author

@sxzz Done.

@netlify
Copy link

netlify bot commented Oct 20, 2023 •
edited
Loading

❌ Deploy Preview for vue-sfc-playground failed.

Name Link
🔨 Latest commit 885ec72
🔍 Latest deploy log https://app.netlify.com/sites/vue-sfc-playground/deploys/6531eaf891f78e0008ed098d

@haoqunjiang
Copy link
Member

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Oct 30, 2023

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools ✅ success ✅ success
nuxt ✅ success ✅ success
pinia ✅ success ✅ success
quasar ✅ success ✅ success
router ✅ success ✅ success
test-utils ✅ success ✅ success
vant ✅ success ✅ success
vite-plugin-vue ✅ success ✅ success
vitepress ✅ success ✅ success
vue-i18n ✅ success ✅ success
vue-macros ✅ success ✅ success
vuetify ✅ success ✅ success
vueuse ✅ success ✅ success
vue-simple-compiler ✅ success ✅ success

@haoqunjiang haoqunjiang merged commit a989345 into vuejs:main Oct 30, 2023
11 checks passed
@haoqunjiang haoqunjiang changed the title fix(compile-sfc): Support define Error as prop type fix(compile-sfc): support Error type in defineProps Oct 30, 2023
@zhmushan zhmushan deleted the define_error branch October 30, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxzz sxzz sxzz approved these changes

@haoqunjiang haoqunjiang haoqunjiang approved these changes

Assignees
No one assigned
Labels
🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. scope: script-setup
Projects
Issue / PR Management
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhmushan @sxzz @haoqunjiang @vue-bot