Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-core): support any signature for Options API lifecycle #5914

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

liulinboyi
Copy link
Member

@liulinboyi liulinboyi commented May 13, 2022

close #5909
fix(runtime-core): support any signature for Options API lifecycle

@liulinboyi liulinboyi changed the title fix(runtime-core): support Promise<void> signature for Options API lifecycle fix(runtime-core): support any signature for Options API lifecycle May 19, 2022
@liulinboyi liulinboyi requested a review from yyx990803 May 19, 2022 02:37
Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB 38 kB 34.2 kB
vue.global.prod.js 159 kB 57.9 kB 51.4 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.9 kB 18.3 kB 16.7 kB
createApp 55 kB 21.3 kB 19.4 kB
createSSRApp 59 kB 23 kB 20.9 kB
defineCustomElement 59.8 kB 22.8 kB 20.8 kB
overall 68.7 kB 26.3 kB 24 kB

Copy link

pkg-pr-new bot commented Oct 23, 2024

Open in Stackblitz

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@5914

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@5914

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@5914

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@5914

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@5914

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@5914

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@5914

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@5914

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@5914

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@5914

vue

pnpm add https://pkg.pr.new/vue@5914

commit: cfeeff1

@edison1105 edison1105 added ready to merge The PR is ready to be merged. scope: types 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. labels Oct 23, 2024
@dgautsch
Copy link

@yyx990803 Is this change ready to be merged? We have a number of async mounted calls in our options API and would love to have these changes in place. It's a large codebase with a lot of legacy components that can't be readily converted to composition API. Thanks so much.

@yyx990803 yyx990803 merged commit 06310e8 into vuejs:main Nov 19, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. ready to merge The PR is ready to be merged. scope: types
Projects
Development

Successfully merging this pull request may close these issues.

Typescript definition of 'mounted' in Options API should support Promise<void> signature
4 participants