types(reactivity): disallow using functions with arguments as a computed getter (fix #5692)

[unshame]

See #5692

This came up during refactoring: I had a computed that was using a vuex getter.

declare const getItems: () => Item[];

const items = computed(getItems);

Then I refactored getItems to require a parent id.

declare const getItems: (parentId: string) => Item[];

const items = computed(getItems);

And typescript didn't notify me that getItems was used incorrectly.

I ended up banning passing functions into computed directly with no-restricted-syntax eslint rule.

            {
                selector: 'CallExpression[callee.name=computed] > Identifier.arguments',
                message: 'Using computed(callback) is unsafe. Use computed(() => callback()) instead.',
            }

But I don't see why the type for ComputedGetter is declared as it is. Surely there can't be a case where doing the following is valid:

const foo = computed((bar: string) => bar);

[netlify]

✅ Deploy Preview for vuejs-coverage ready!

Name	Link
🔨 Latest commit	931f0b8a6b594faae0394e8618b93ddfa1918b25
🔍 Latest deploy log	https://app.netlify.com/sites/vuejs-coverage/deploys/62584b55c657bd000801d27a
😎 Deploy Preview	https://deploy-preview-5695--vuejs-coverage.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[netlify]

✅ Deploy Preview for vue-sfc-playground ready!

Name	Link
🔨 Latest commit	931f0b8a6b594faae0394e8618b93ddfa1918b25
🔍 Latest deploy log	https://app.netlify.com/sites/vue-sfc-playground/deploys/62584b5525209500073ea26b
😎 Deploy Preview	https://deploy-preview-5695--vue-sfc-playground.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[netlify]

✅ Deploy Preview for vue-next-template-explorer ready!

Name	Link
🔨 Latest commit	931f0b8a6b594faae0394e8618b93ddfa1918b25
🔍 Latest deploy log	https://app.netlify.com/sites/vue-next-template-explorer/deploys/62584b55461eb2000832aecd
😎 Deploy Preview	https://deploy-preview-5695--vue-next-template-explorer.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[yyx990803]

Unfortunately the relaxed arguments type seems necessary for the type tests to pass.

[unshame]

I relaxed the type back to what it was but only applied it for computed options. All tests should be passing now.

[yyx990803]

Let's rename this to ComputedGetterWithInstance

[unshame]

Done

[unshame]

Any chance to get this merged?

[yyx990803]

Sorry I wasn't more explicit but this needs to be renamed to ...WithInstance for consistency

[unshame]

It should be good now.

[unshame]

@yyx990803 any chance to get this merged?

[skirtles-code]

I was wondering whether this PR is still needed since the changes in #9497? That PR introduced the oldValue as an argument, with corresponding changes to the relevant types. The ...args: any[] is now gone.