fix(runtime-core): inherit attrs inconsistent (#2549） #2640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
07akioni
reviewed
Nov 24, 2020
| @@ -247,6 +253,20 @@ const getChildRoot = ( | |||
| return [normalizeVNode(childRoot), setRoot] | |||
| } | |||
|
|
|||
| const isRootCommentEffectChild = (vnode: VNode): boolean => { | |||
| let children = vnode.children | |||
There was a problem hiding this comment.
const { children } = vnode
07akioni
reviewed
Nov 24, 2020
| let children = vnode.children | ||
| if (isArray(children)) { | ||
| let isFragmentChild = false | ||
| let comments = children.filter(child => { |
luwuer
force-pushed
the
inherit-attrs-inconsistent-between-dev-and-prod
branch
from
0caaa0e to
e5ba1ce
Compare
|
Thanks for the PR, but this is an incomplete fix. The more accurate fix is by detecting such cases at compile time. See 3bc2914 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2549
Determine if child component is effected by root comments before invoke
getChildRootwhen in development environment.