fix(runtime-dom): v-model.number work with select tag #2254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edison1105
changed the title
69hunter
reviewed
Oct 5, 2020
Comment on lines
+176
to
+180
| let domValue: string | number = el.multiple ? selectedVal : selectedVal[0] | ||
|
|
||
| if (castToNumber) { | ||
| domValue = toNumber(domValue) | ||
| } |
There was a problem hiding this comment.
@edison1105, I would suggest handling the case of multiple select here.
When the el.multiple is true, domValue will be assigned with an array from selectedVal.
The domValue = toNumber(domValue) will cast an array of numbers to number.
This will make the multiple select case throw an error of:
<select multiple v-model> expects an Array or Set value for its binding, but got Number.
There was a problem hiding this comment.
Thanks~ @69hunter. I will update this.
|
closed this PR, because the repo of this PR is deleted.😂😂😂. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2252