Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssr): avoid updating subtree of async component if it is resolved #12363

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

edison1105
Copy link
Member

close #12362

Copy link

github-actions bot commented Nov 12, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB (+25 B) 38 kB (+5 B) 34.2 kB (+11 B)
vue.global.prod.js 159 kB (+25 B) 57.9 kB (+6 B) 51.4 kB (-4 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.9 kB 18.3 kB 16.7 kB
createApp 55 kB 21.3 kB 19.4 kB
createSSRApp 59 kB (+25 B) 23 kB (+5 B) 20.9 kB (-62 B)
defineCustomElement 59.8 kB 22.8 kB 20.8 kB
overall 68.7 kB 26.3 kB 24 kB

Copy link

pkg-pr-new bot commented Nov 12, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@12363

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@12363

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@12363

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@12363

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@12363

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@12363

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@12363

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@12363

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@12363

vue

pnpm add https://pkg.pr.new/vue@12363

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@12363

commit: 5c83f47

@edison1105 edison1105 changed the title fix(ssr): avoid updating subtree of async component fix(ssr): avoid updating subtree of async component if it is resolved Nov 12, 2024
@edison1105 edison1105 added ready to merge The PR is ready to be merged. scope: ssr 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. labels Nov 12, 2024
@aKzenT
Copy link

aKzenT commented Nov 12, 2024

thanks for the quick fix. I can confirm that this PR fixes the two bugs we noticed in our project and which prompted me to create the issue.

@yyx990803 yyx990803 merged commit da7ad5e into main Nov 15, 2024
15 checks passed
@yyx990803 yyx990803 deleted the edison/fix/12362 branch November 15, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. ready to merge The PR is ready to be merged. scope: ssr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v-show causes async component child to be recreated in SSR mode
3 participants