-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Transition): handle KeepAlive child unmount in Transition out-in mode #11778
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
811c84f
fix(Transition): avoid leave hooks call multiple times
edison1105 b2a5b16
chore: minor tweaks
edison1105 3189297
test: add test case
edison1105 239f912
chore: update
edison1105 f135eee
chore: update
edison1105 29735cb
Merge branch 'main' into edison/fix/11775
edison1105 fe73487
wip: save
edison1105 9c6cd9e
wip: save
edison1105 1b897a4
chore: fix #10827
edison1105 32bc95c
Merge branch 'main' into edison/fix/11775
edison1105 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -224,6 +224,7 @@ const BaseTransitionImpl: ComponentOptions = { | |
if (!(instance.job.flags! & SchedulerJobFlags.DISPOSED)) { | ||
instance.update() | ||
} | ||
delete leavingHooks.afterLeave | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this line fixes problem 1 |
||
} | ||
return emptyPlaceholder(child) | ||
} else if (mode === 'in-out' && innerChild.type !== Comment) { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -267,7 +267,7 @@ const KeepAliveImpl: ComponentOptions = { | |
pendingCacheKey = null | ||
|
||
if (!slots.default) { | ||
return null | ||
return (current = null) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this line fixes problem 2, but it will lead to #10827 regression. |
||
} | ||
|
||
const children = slots.default() | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this line fixes #10827