fix(runtime-core): app.provide throws a warning when assigning the same value. #10337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size ReportBundles
Usages
|
OnlyWick
force-pushed
the
allow-provide-reassignment
branch
from
441334f
to
cf0ef58
Compare
OnlyWick
changed the title
…ning should be thrown
OnlyWick
changed the title
| warn( | ||
| `App already provides property with key "${String(key)}". ` + | ||
| `It will be overwritten with the new value.`, | ||
| ) | ||
| } | ||
|
|
||
| context.provides[key as string | symbol] = value | ||
| if (isValueChanged) { |
There was a problem hiding this comment.
if (isValueChanged) { could be merged with previous if
There was a problem hiding this comment.
Are you suggesting to put it inside an else block? Since the value is already the same, there is no need to perform the assignment again.
There was a problem hiding this comment.
no
if (isValueChanged) {
if (...) warn()
context.provides[key as string | symbol] = newVal
}
|
Perhaps the warning needs to be optimized? I think if the same value is assigned, it should only warn the user that the same value already exists, instead of warning the user about overwriting the old value with a new one. |
|
I don't think this is necessary. Providing the same value twice is pointless and should also be avoided if possible so a warning is appropriate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If providing the same value to app.provide, no warning should be thrown.