Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nested elements with key event+modifiers do not call listener function #9849

Closed
davidglezz opened this issue Dec 16, 2023 · 1 comment · Fixed by #9851
Closed

Nested elements with key event+modifiers do not call listener function #9849

davidglezz opened this issue Dec 16, 2023 · 1 comment · Fixed by #9851
Labels
🐞 bug Something isn't working

Comments

@davidglezz
Copy link

davidglezz commented Dec 16, 2023 •
edited
Loading

Vue version

3.3.10

Link to minimal reproduction

https://stackblitz.com/edit/github-dpq7nx-azo6wj?file=src%2Fcomponents%2FHelloWorld.vue

Steps to reproduce

# Works
npm i [email protected]
vitest --run

# Fail
npm i [email protected]
vitest --run

What is expected?

The test should pass successfully.

Manual test

Clicking on the button to focus it
pressing y key should call remove() function which logs 'Called!' but it not happens.

Expected:

pressing x -> logs 'Called!'
pressing y -> logs 'Called!'

Actual:

pressing x -> logs 'Called!' Twice
pressing y -> does nothing.

What is actually happening?

It requires an element and its parent with an event listener to the same method.

System Info

No response

Any additional comments?

No response
@davidglezz davidglezz changed the title Nested key event with modifiers don’t call the listener function Nested elements with key event+modifiers do not call listener function Dec 16, 2023
@davidglezz davidglezz mentioned this issue Dec 16, 2023
Closed
@LinusBorg LinusBorg added the 🐞 bug Something isn't working label Dec 16, 2023
@LinusBorg
Copy link
Member

This is a chaching issue in the withKeys() helper.

@yangxiuxiu1115 yangxiuxiu1115 mentioned this issue Dec 16, 2023
Closed
LinusBorg added a commit that referenced this issue Dec 16, 2023
@LinusBorg
fix(runtime-dom): cache event handlers by key/modifiers (fix #9849)
ae6b848
@LinusBorg LinusBorg mentioned this issue Dec 16, 2023
Merged
yyx990803 pushed a commit that referenced this issue Dec 16, 2023
@LinusBorg
fix(runtime-dom): cache event handlers by key/modifiers (#9851)
04d2c05 
close #9849
yyx990803 pushed a commit to smallnine9/core that referenced this issue Dec 19, 2023
@LinusBorg @yyx990803
fix(runtime-dom): cache event handlers by key/modifiers (vuejs#9851)
70e6c6a 
close vuejs#9849
@github-actions github-actions bot locked and limited conversation to collaborators Dec 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🐞 bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@davidglezz @LinusBorg