fix(custom-element): correctly handle number type props in prod #8989

baiwusanyu-c · 2023-08-16T15:46:16Z

packages/runtime-dom/src/apiCustomElement.ts

packages/compiler-sfc/src/script/defineProps.ts

github-actions · 2023-08-21T05:59:01Z

Size Report

Bundles

File	Size	Gzip	Brotli
runtime-dom.global.prod.js	86.7 kB	33 kB	29.8 kB
vue.global.prod.js	133 kB	49.8 kB	44.7 kB

Usages

Name	Size	Gzip	Brotli
createApp	48.2 kB	19 kB	17.3 kB
createSSRApp	51.5 kB	20.3 kB	18.5 kB
defineCustomElement	50.6 kB	19.7 kB	18 kB
overall	61.6 kB	23.8 kB	21.7 kB

packages/compiler-sfc/src/script/context.ts

…ix/CENumProps

packages/compiler-sfc/src/compileScript.ts

SavkaTaras · 2023-08-24T18:11:21Z

Hello @baiwusanyu-c , could you please merge this PR, once all approved? Thank you so much!

sxzz · 2023-08-24T18:22:54Z

@SavkaTaras Hi, we Vue team has a specific cycle to merge PRs and release, please be patient ❤️

SavkaTaras · 2023-08-24T18:34:17Z

@SavkaTaras Hi, we Vue team has a specific cycle to merge PRs and release, please be patient ❤️

@sxzz thank you so much! I appreciate it.

SavkaTaras · 2023-11-07T16:11:06Z

Hello @edison1105 , could you please review this at your convenience?
We are kindly waiting on this to be released...

Thank you.

# Conflicts: # packages/compiler-sfc/__tests__/compileScript/defineProps.spec.ts # packages/runtime-dom/src/jsx.ts

LinusBorg · 2023-11-30T20:08:31Z

@edison1105 This is technically pending your review. Can you have a look or cancel your review? I think this is good to go.

edison1105 · 2023-12-01T01:20:29Z

@LinusBorg approved

SavkaTaras · 2023-12-04T14:59:14Z

Hello @baiwusanyu-c @sxzz @LinusBorg @edison1105 ,

Can you please merge this and release when possible?

Thank you

yyx990803 · 2023-12-07T02:53:42Z

@sxzz looks like this will need to merge and publish the corresponding changes in the Vite plugin, I'll leave that to you

sxzz · 2023-12-07T05:39:40Z

Released as [email protected]

SavkaTaras · 2023-12-07T12:25:47Z

Released as [email protected]

Hello, is it possible to release 4.5.2? Thank you

sxzz · 2023-12-07T12:50:29Z

Released as [email protected] too

baiwusanyu-c added 2 commits August 16, 2023 23:45

fix(custom-element): Correctly handle number type props in prod

7306078

fix(custom-element): added unit test

981852f

baiwusanyu-c marked this pull request as ready for review August 16, 2023 16:07

edison1105 requested changes Aug 17, 2023

View reviewed changes

packages/runtime-dom/src/apiCustomElement.ts Outdated Show resolved Hide resolved

baiwusanyu-c added 2 commits August 17, 2023 14:04

chore: remove console

df02ef9

chore: remove expect

bd3b0f5

baiwusanyu-c requested a review from edison1105 August 17, 2023 06:17

chore: updated complier

ad7dd23

sxzz changed the title ~~fix(custom-element): Correctly handle number type props in prod~~ fix(custom-element): correctly handle number type props in prod Aug 18, 2023

sxzz requested changes Aug 18, 2023

View reviewed changes

packages/compiler-sfc/src/script/defineProps.ts Outdated Show resolved Hide resolved

packages/compiler-sfc/src/script/defineProps.ts Outdated Show resolved Hide resolved

baiwusanyu-c added 3 commits August 21, 2023 08:48

chore: format code

057886a

chore: added isCE option to compiler sfc ctx

b0d7417

chore: updated unit test

8f1da9a

baiwusanyu-c requested a review from sxzz August 21, 2023 01:39

sxzz force-pushed the main branch from 39d4fc1 to 1b56405 Compare August 21, 2023 05:00

Merge branch 'main' into bwsy/fix/CENumProps

cc0ff63

sxzz reviewed Aug 21, 2023

View reviewed changes

packages/compiler-sfc/src/script/context.ts Outdated Show resolved Hide resolved

chore: added customElement options in SFCScriptCompileOptions

4a651d1

baiwusanyu-c requested a review from sxzz August 22, 2023 02:18

baiwusanyu-c and others added 2 commits August 22, 2023 10:18

Merge branch 'main' into bwsy/fix/CENumProps

f070820

Merge remote-tracking branch 'origin/bwsy/fix/CENumProps' into bwsy/f…

26fd1e3

…ix/CENumProps

sxzz reviewed Aug 22, 2023

View reviewed changes

packages/compiler-sfc/src/compileScript.ts Outdated Show resolved Hide resolved

chore: updated code

dbfaf97

baiwusanyu-c mentioned this pull request Aug 22, 2023

feat(plugin-vue): add customElement option to compiler vitejs/vite-plugin-vue#238

Merged

9 tasks

baiwusanyu-c requested a review from sxzz August 22, 2023 06:59

sxzz reviewed Aug 22, 2023

View reviewed changes

packages/compiler-sfc/src/compileScript.ts Show resolved Hide resolved

sxzz approved these changes Aug 22, 2023

View reviewed changes

sxzz added the ready to merge The PR is ready to be merged. label Aug 22, 2023

sxzz mentioned this pull request Aug 27, 2023

feat(compileStyle): support :is and :where selector #8929

Merged

baiwusanyu-c added the scope: custom elements label Aug 30, 2023

baiwusanyu-c added 2 commits September 5, 2023 15:25

Merge branch 'main' into bwsy/fix/CENumProps

916388e

Merge branch 'main' into bwsy/fix/CENumProps

64f9c5d

LinusBorg approved these changes Oct 21, 2023

View reviewed changes

baiwusanyu-c added 3 commits October 26, 2023 23:02

Merge branch 'main' into bwsy/fix/CENumProps

6d0c7b4

Merge branch 'main' into bwsy/fix/CENumProps

d2d98e6

Merge branch 'main' into bwsy/fix/CENumProps

af82b74

baiwusanyu-c and others added 4 commits November 10, 2023 14:27

Merge branch 'main' into bwsy/fix/CENumProps

a7d48fb

[autofix.ci] apply automated fixes

d73f608

Merge remote-tracking branch 'origin/main' into bwsy/fix/CENumProps

eb89b9e

# Conflicts: # packages/compiler-sfc/__tests__/compileScript/defineProps.spec.ts # packages/runtime-dom/src/jsx.ts

Merge branch 'main' into bwsy/fix/CENumProps

3564fce

edison1105 approved these changes Dec 1, 2023

View reviewed changes

Merge branch 'main' into bwsy/fix/CENumProps

3640d9f

LinusBorg merged commit d74d364 into vuejs:main Dec 6, 2023
11 checks passed

baiwusanyu-c deleted the bwsy/fix/CENumProps branch December 6, 2023 07:18

LinusBorg mentioned this pull request Dec 7, 2023

Vue3 custom element prop type number is a string in production. #8987

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(custom-element): correctly handle number type props in prod #8989

fix(custom-element): correctly handle number type props in prod #8989

baiwusanyu-c commented Aug 16, 2023 •

edited

Loading

github-actions bot commented Aug 21, 2023 •

edited

Loading

SavkaTaras commented Aug 24, 2023

sxzz commented Aug 24, 2023 •

edited

Loading

SavkaTaras commented Aug 24, 2023

SavkaTaras commented Nov 7, 2023

LinusBorg commented Nov 30, 2023

edison1105 commented Dec 1, 2023

SavkaTaras commented Dec 4, 2023

yyx990803 commented Dec 7, 2023

sxzz commented Dec 7, 2023

SavkaTaras commented Dec 7, 2023

sxzz commented Dec 7, 2023

fix(custom-element): correctly handle number type props in prod #8989

fix(custom-element): correctly handle number type props in prod #8989

Conversation

baiwusanyu-c commented Aug 16, 2023 • edited Loading

github-actions bot commented Aug 21, 2023 • edited Loading

Size Report

Bundles

Usages

SavkaTaras commented Aug 24, 2023

sxzz commented Aug 24, 2023 • edited Loading

SavkaTaras commented Aug 24, 2023

SavkaTaras commented Nov 7, 2023

LinusBorg commented Nov 30, 2023

edison1105 commented Dec 1, 2023

SavkaTaras commented Dec 4, 2023

yyx990803 commented Dec 7, 2023

sxzz commented Dec 7, 2023

SavkaTaras commented Dec 7, 2023

sxzz commented Dec 7, 2023

baiwusanyu-c commented Aug 16, 2023 •

edited

Loading

github-actions bot commented Aug 21, 2023 •

edited

Loading

sxzz commented Aug 24, 2023 •

edited

Loading