-
-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugin-vue): add customElement
option to compiler
#238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sxzz
reviewed
Aug 22, 2023
Co-authored-by: 三咲智子 Kevin Deng <[email protected]>
baiwusanyu-c
commented
Aug 22, 2023
sxzz
reviewed
Aug 22, 2023
sxzz
changed the title
feat: added customElement option to vue compiler
feat(plugin-vue): add Aug 24, 2023
customElement
option to compiler
# Conflicts: # packages/plugin-vue/src/index.ts
sxzz
reviewed
Dec 6, 2023
sxzz
approved these changes
Dec 6, 2023
Looks like CI failed. |
sxzz
added a commit
that referenced
this pull request
Dec 7, 2023
Co-authored-by: 三咲智子 Kevin Deng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to the filter result of vite-plugin-vue, the compiler like vue passes the customElement option parameter
Additional context
wait upstream vuejs/core#8989What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).