Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stringifyStatic get wrong attributes #6617

Closed
zjffun opened this issue Sep 7, 2022 · 3 comments · Fixed by #6635
Closed

stringifyStatic get wrong attributes #6617

zjffun opened this issue Sep 7, 2022 · 3 comments · Fixed by #6635
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. 🐞 bug Something isn't working scope: compiler

Comments

@zjffun
Copy link

zjffun commented Sep 7, 2022 •
edited by posva
Loading

Vue version

3.2.36

Link to minimal reproduction

Open this link https://stackblitz.com/edit/vue-jkfe1i?file=src%2FApp.vue,src%2Fmain.js

SFC Playground

Steps to reproduce

Open https://stackblitz.com/edit/vue-jkfe1i?file=src%2FApp.vue,src%2Fmain.js

What is expected?

Button not disabled

What is actually happening?

Button is disabled

System Info

No response

Any additional comments?

Looks like we need to check the type of value here
@zjffun
Copy link
Author

zjffun commented Sep 7, 2022

Related issue #6568

@edison1105 edison1105 added 🐞 bug Something isn't working scope: compiler 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. labels Sep 8, 2022
@yuanxin518
Copy link

playground

Looks good.

@edison1105
Copy link
Member

@Circkoooooo
see sfc

moushicheng added a commit to moushicheng/core that referenced this issue Sep 9, 2022
@moushicheng
fix(stringifyStatic):remove boolean attribute for alse (vuejs#6617)
5f812f1
moushicheng added a commit to moushicheng/core that referenced this issue Sep 9, 2022
@moushicheng
fix(stringifyStatic):remove boolean attribute for false (vuejs#6617)
0dea32d
@moushicheng moushicheng mentioned this issue Sep 9, 2022
Merged
yyx990803 pushed a commit that referenced this issue Sep 27, 2022
@moushicheng
fix(compiler-core): remove v-bind boolean attribute with literal fals…
fd7f9f9 
…e value when stringifying (#6635)

fix #6617
yyx990803 pushed a commit that referenced this issue Sep 27, 2022
@moushicheng @yyx990803
fix(compiler-dom): remove v-bind boolean attribute with literal false…
6c6fe2c 
… value when stringifying (#6635)

fix #6617
chrislone pushed a commit to chrislone/core that referenced this issue Feb 4, 2023
@moushicheng
fix(compiler-dom): remove v-bind boolean attribute with literal false…
b5e3513 
… value when stringifying (vuejs#6635)

fix vuejs#6617
@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. 🐞 bug Something isn't working scope: compiler
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(stringifyStatic):remove boolean attribute for false (fix #6617) moushicheng/core
3 participants
@edison1105 @zjffun @yuanxin518