Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forwarded slots not updating using template tags #4123

Closed
robertmoura opened this issue Jul 15, 2021 · 0 comments · Fixed by #4124
Closed

Forwarded slots not updating using template tags #4123

robertmoura opened this issue Jul 15, 2021 · 0 comments · Fixed by #4124
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. 🐞 bug Something isn't working scope: compiler scope: slots

Comments

@robertmoura
Copy link

robertmoura commented Jul 15, 2021 •
edited
Loading

Version

3.1.4

Reproduction link

SFC reproduction

Steps to reproduce

Click on the "Change data" button and see that the data doesn't change.

What is expected?

The item label should change.

What is actually happening?

The slot isn't rendering again

I came into this issue while forwarding slot like this:

<Comp>
    <template #default="data">
        <slot v-bind="data"></slot>
    </template>
</Comp>

Looking at the generated code, it looks as if normal slots are marked as forwarded, but tagged templates (e.g. <template #default>) are marked as stable.
@LinusBorg LinusBorg added 🐞 bug Something isn't working scope: compiler scope: slots ❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. labels Jul 15, 2021
@edison1105 edison1105 mentioned this issue Jul 15, 2021
Merged
yyx990803 pushed a commit that referenced this issue Jul 15, 2021
@edison1105
fix(compiler-core): fix forwarded slots detection on template slots (#…
c23153d 
…4124)

fix #4123
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. 🐞 bug Something isn't working scope: compiler scope: slots
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(compiler-core): forwarded slots work with template tag edison1105/vuejs-core
2 participants
@LinusBorg @robertmoura