Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve template CI tests #1218

Merged
merged 43 commits into from
Jan 13, 2018
Merged

Improve template CI tests #1218

merged 43 commits into from
Jan 13, 2018

Conversation

LinusBorg
Copy link
Contributor

@LinusBorg LinusBorg commented Jan 4, 2018 •
edited
Loading

This PR completely changes the CI testing setup for the template - not projects generated with it, so id doesn't affect users in any way.

Changes

  • introduces ability to test different answer scenarios.
  • no more test.sh, simply set an env variable to roll out a template with a defined set of answers.
  • uses circleCI 2.0 now, for improved performance. all scenarios (currently 3) are tested in parallel.

Scenarios

Minimal

Answers "no", to all choices, so the absolutely basic setup.

Full

Answers "yes" to all choices, using the default value where possible. so it runs unit tests with jest and eslint with the "standard" config

Full-karma-airbnb

Like "Full", but uses karma instead of jest and airbnb eslint config instead of standard.

Open TODOs:

  • add npm script to run tests locally
  • remove test.sh file

LinusBorg added 30 commits January 4, 2018 16:08
@LinusBorg
Batman!
e10cb12
@LinusBorg
fix wrong job name
0205c22
@LinusBorg
fix working dir paths
d38941d
@LinusBorg
fix node_modules path
124af6d
@LinusBorg
test other step order
d9664a2
@LinusBorg
try other shell
9dc3f68
@LinusBorg
...and another one
520638d
@LinusBorg
rewrite test.sh
64e0906
@LinusBorg
try running a bash script instead
07aa3ff
@LinusBorg
and another attempt.
5a9afe9
@LinusBorg
make executable
64e2cb3
@LinusBorg
anpother try...
e4518d2
@LinusBorg
fix workflow errors
60b1d9c
@LinusBorg
fix path
3c876d9
@LinusBorg
Batman!
acab0ee
@LinusBorg
added scenarios and made it work!!
36121bd
@LinusBorg
refactors and comments
82298f7
@LinusBorg
just fumbling around
82d72dd
@LinusBorg
adfda
37f60c9
@LinusBorg
adjust test scenarios for autoInstall
96996da
@LinusBorg
x<vb<xb
10fac73
@LinusBorg
first try since a long time
8c60a52
@LinusBorg
small fix
b31df03
@LinusBorg
fix path to vue-cli
d1ff81c
@LinusBorg
fix scenarios
b2827f1
@LinusBorg
fix persist paths
1b8093b
@LinusBorg
testing with quotes for the path
013616a
@LinusBorg
removing unhelpful quotes
0c22cdf
@LinusBorg
New Test
a071d5c
@LinusBorg
fixed indentation
6768b24
This was referenced Jan 4, 2018
Closed
Closed
@LinusBorg LinusBorg mentioned this pull request Jan 5, 2018
Open
@Toilal
Copy link
Contributor

Toilal commented Jan 5, 2018

It's actually far better than expect scripts ! Thanks :)

It's a shame inquirer.js doesn't support some kind of automation, the isNotTest variable seems like a hack, but it's still better than expect script that are just *** to build and maintain.

@Toilal
Copy link
Contributor

Toilal commented Jan 5, 2018

(Don't forget to squash commits 🤣 🍭)

@LinusBorg
Copy link
Contributor Author

Oh, I always squash PRs, but this one needs it badly - I fought with circleci config forever 😂😂

This was referenced Jan 6, 2018
Open
Closed
@codetheorist
Copy link

Could we not do away with the shell script all together now. If all of the answers are in scenarios, there's technically no need for the yes command.

Would there be a way to run all scenarios with one command?

@LinusBorg
Copy link
Contributor Author

LinusBorg commented Jan 9, 2018 •
edited
Loading

Oh right, the fact that the test.sh file is still there is an oversight.

And I should add an npm script to run those tests in sequence.

For CI we run them in parallel with circleci commands, that's why in haven't added a script yet.

@LinusBorg LinusBorg mentioned this pull request Jan 10, 2018
Closed
@LinusBorg LinusBorg modified the milestones: 1.3.0, 1.4.0 Jan 10, 2018
@LinusBorg
remove test.sh
730f331 
not needed anymore
@LinusBorg LinusBorg merged commit fd65d24 into develop Jan 13, 2018
LinusBorg added a commit that referenced this pull request Jan 13, 2018
@LinusBorg
Merge branch 'develop'
8343cae 
* develop:
  bump template version (1.3.0)
  chore: remove extra comma (#1240)
  Improve template CI tests (close #1218)
  Revert "fix bad alias (fix #1239)"
  Typo, whitespace and Style Guide fixes (#1231)
  Update runner.js (#1235)
  remove unnecessary option.
  bumping eslint dependencies
  fix bad alias (fix #1239)
  remove duplicate lines in gitignore (#1214)
  fix historyFallback rewrite for Windows systems
  improved comments in eslintrc
  updated linting docs.
  respect eslint rule for order of options.
  switch to essential ruleset.
  add eslint-plugin-vue

# Conflicts:
#	template/build/build.js
@LinusBorg LinusBorg mentioned this pull request Jan 19, 2018
Closed
c0defre4k added a commit to neonblack-at/webpack that referenced this pull request Jan 23, 2018
@c0defre4k
Merge remote-tracking branch 'vuejs-templates/master'
27a2763 
* vuejs-templates/master: (66 commits)
  Bump template version (1.3.1)
  change circleci node image to 6.12.3 to ensure node 6 compat.
  replace object rest spread with Object.assign for node6 compat. (fix
vuejs-templates#1245)
  bump template version (1.3.0)
  chore: remove extra comma (vuejs-templates#1240)
  Improve template CI tests (close vuejs-templates#1218)
  Revert "fix bad alias (fix vuejs-templates#1239)"
  Typo, whitespace and Style Guide fixes (vuejs-templates#1231)
  Update runner.js (vuejs-templates#1235)
  remove unnecessary option.
  bumping eslint dependencies
  fix bad alias (fix vuejs-templates#1239)
  fix history fallback for windows.
  remove duplicate lines in gitignore (vuejs-templates#1214)
  fix historyFallback rewrite for Windows systems
  improved comments in eslintrc
  updated linting docs.
  respect eslint rule for order of options.
  switch to essential ruleset.
  add eslint-plugin-vue
  ...

# Conflicts:
#	meta.js
#	template/package.json
#	template/src/components/HelloWorld.vue
#	template/src/main.js
@Kocal Kocal mentioned this pull request May 5, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toeioriginal77 toeioriginal77 toeioriginal77 approved these changes

Assignees
No one assigned
Labels
enhancement PR:Review in Progress
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@LinusBorg @Toilal @codetheorist @toeioriginal77