Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint config clean up #1093

Merged
merged 3 commits into from
Dec 2, 2017
Merged

ESLint config clean up #1093

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1c833e5
Remove unnecessary quotes from .eslintrc.js
exarus Nov 21, 2017
9eaba75
ESLint config is more explicit
exarus Nov 21, 2017
f436301
Remove redundant rule for ESLint Standard JS
exarus Nov 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions template/.eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,34 +22,34 @@ module.exports = {
],
{{#if_eq lintConfig "airbnb"}}
// check if imports actually resolve
'settings': {
settings: {
'import/resolver': {
'webpack': {
'config': 'build/webpack.base.conf.js'
webpack: {
config: 'build/webpack.base.conf.js'
}
}
},
{{/if_eq}}
// add your custom rules here
'rules': {
rules: {
{{#if_eq lintConfig "standard"}}
// allow paren-less arrow functions
'arrow-parens': 0,
'arrow-parens': 'off',
// allow async-await
'generator-star-spacing': 0,
'generator-star-spacing': 'off',
{{/if_eq}}
{{#if_eq lintConfig "airbnb"}}
// don't require .vue extension when importing
'import/extensions': ['error', 'always', {
'js': 'never',
'vue': 'never'
js: 'never',
vue: 'never'
}],
// allow optionalDependencies
'import/no-extraneous-dependencies': ['error', {
'optionalDependencies': ['test/unit/index.js']
optionalDependencies: ['test/unit/index.js']
}],
{{/if_eq}}
// allow debugger during development
'no-debugger': process.env.NODE_ENV === 'production' ? 2 : 0
'no-debugger': process.env.NODE_ENV === 'production' ? 'error' : 'off'
}
}