Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prod conf is loaded when npm run dev #877

Closed
lucidfrontier45 opened this issue Aug 28, 2017 · 1 comment
Closed

prod conf is loaded when npm run dev #877

lucidfrontier45 opened this issue Aug 28, 2017 · 1 comment

Comments

@lucidfrontier45
Copy link

The recent change of #864 is problematic since webpack.prod.conf.js is loaded when running dev-server by npm run dev. The most critical problem for me is that the auto-reload feature doesn't work at all.

I don't know the context of the fix #864 but the conditional operator seems wrong.

Changing

var webpackConfig = process.env.NODE_ENV === 'testing' || 'production'
  ? require('./webpack.prod.conf')
  : require('./webpack.dev.conf')

to

var webpackConfig = (process.env.NODE_ENV === 'testing' || process.env.NODE_ENV === 'production')
  ? require('./webpack.prod.conf')
  : require('./webpack.dev.conf')

works for me.
@LinusBorg
Copy link
Contributor

LinusBorg commented Aug 28, 2017 •
edited
Loading

Oh damn, that was my mistake for merging it like this. Will correct in a second!

Thanks for reporting it!

@joustava joustava mentioned this issue Aug 28, 2017
Closed
JasonGrubb pushed a commit to JasonGrubb/webpack that referenced this issue Aug 30, 2017
@rwb7041 @JasonGrubb
Beltrw mods (#9)
f1b859d 
* babel should keep code comments. (fix vuejs-templates#730) (vuejs-templates#753)

They are necessary for webpacks "magic comments" to work, e.g. with `import(/* webpackChunkName: "chunk1" */ './component.vue')`

* build: Configure targets.browser for babel-preset-env (vuejs-templates#763)

* Remove inconsistent spacing (vuejs-templates#754)

* feat(gitignore): include common editor directories (vuejs-templates#774)

* feat(gitignore): include common editor directories

add common editor files and directories to .gitignore

closes vuejs-templates#772

* feat(gitignore): remove .vscode directory

remove .vscode directory from .gitignore

* Video audio loader (vuejs-templates#765)

* gitignore vscode

* media loader

audio and video tag

* Remove vscode gitignore

* Add \n back

* fix missing closing bracket

* add default values (img, image)

* Upgrade vue-router to v2.6.0 (vuejs-templates#777)

* Fix console error (vuejs-templates#784)

Fix console error`Failed to load resource: net::ERR_INCOMPLETE_CHUNKED_ENCODING`

* Fix proxy example (fix vuejs-templates#780)

the glob pattern was too narrow, woudl not catch subpaths.

* Fix autoprefixer explanation (vuejs-templates#798)

The parameter to set in package.json is named "browserslist".

* chore: Bump dev dependencies for template (vuejs-templates#790)

* fix: Use false to disable webpack-hot-middleware log (vuejs-templates#778)

* Move Chat: Gitter -> Discord (vuejs-templates#869)

* Remove unnecessary space and comma (vuejs-templates#866)

* load webpack.prod.conf when NODE_ENV=production (vuejs-templates#864)

* Return exit code 1 when npm run build fails (vuejs-templates#854)

* fix standard eslint config link (vuejs-templates#834)

* fix ci build faild (vuejs-templates#857)

* Removing Vue.config.debug usage from documentation (vuejs-templates#871)

* Removing Vue.config.debug usage from documentation

It has been removed; https://vuejs.org/v2/guide/migration.html#Vue-config-debug-removed

* Update env.md

* fixed vue-router dependency(need vue-loader@^13.0.0) (vuejs-templates#876)

* bump vue & vue-router dependencies

* Specify the address to listen on (vuejs-templates#759)

Currently, this causes the dev server to listen on all addresses by default, which is not the intended behavior, imo.

* add HashedModuleIdsPlugin when build (vuejs-templates#870)

* Add support for linked modules (vuejs-templates#688)

* chore(package): rm unused lolex dependency(dev) (vuejs-templates#803)

* fix vuejs-templates#877

* Revert vuejs-templates#688, fix vuejs-templates#879

We have to investigate how we can get vuejs-templates#688 work without the error reported in vuejs-templates#879

* revert: vuejs-templates#759

That's actually not a good idea when you e.g. want to access the dev server from your mobile.

* - Re-added check for router
- Modified eslint file to use standard and have M be a global
rwb7041 added a commit to JasonGrubb/webpack that referenced this issue Aug 31, 2017
@rwb7041 @JasonGrubb
Merged in beltrw_mods (pull request #1)
0ed883f 
Beltrw mods

* babel should keep code comments. (fix vuejs-templates#730) (vuejs-templates#753)

    They are necessary for webpacks "magic comments" to work, e.g. with `import(/* webpackChunkName: "chunk1" */ './component.vue')`

* build: Configure targets.browser for babel-preset-env (vuejs-templates#763)

* Remove inconsistent spacing (vuejs-templates#754)

* feat(gitignore): include common editor directories (vuejs-templates#774)

    * feat(gitignore): include common editor directories

    add common editor files and directories to .gitignore

    closes vuejs-templates#772

    * feat(gitignore): remove .vscode directory

    remove .vscode directory from .gitignore

* Video audio loader (vuejs-templates#765)

    * gitignore vscode

    * media loader

    audio and video tag

    * Remove vscode gitignore

    * Add \n back

    * fix missing closing bracket

    * add default values (img, image)

* Upgrade vue-router to v2.6.0 (vuejs-templates#777)

* Fix console error (vuejs-templates#784)

    Fix console error`Failed to load resource: net::ERR_INCOMPLETE_CHUNKED_ENCODING`

* Fix proxy example (fix vuejs-templates#780)

    the glob pattern was too narrow, woudl not catch subpaths.

* Fix autoprefixer explanation (vuejs-templates#798)

    The parameter to set in package.json is named "browserslist".

* chore: Bump dev dependencies for template (vuejs-templates#790)

* fix: Use false to disable webpack-hot-middleware log (vuejs-templates#778)

* Move Chat: Gitter -> Discord (vuejs-templates#869)

* Remove unnecessary space and comma (vuejs-templates#866)

* load webpack.prod.conf when NODE_ENV=production (vuejs-templates#864)

* Return exit code 1 when npm run build fails (vuejs-templates#854)

* fix standard eslint config link (vuejs-templates#834)

* fix ci build faild (vuejs-templates#857)

* Removing Vue.config.debug usage from documentation (vuejs-templates#871)

    * Removing Vue.config.debug usage from documentation

    It has been removed; https://vuejs.org/v2/guide/migration.html#Vue-config-debug-removed

    * Update env.md

* fixed vue-router dependency(need vue-loader@^13.0.0) (vuejs-templates#876)

* bump vue & vue-router dependencies

* Specify the address to listen on (vuejs-templates#759)

    Currently, this causes the dev server to listen on all addresses by default, which is not the intended behavior, imo.

* add HashedModuleIdsPlugin when build (vuejs-templates#870)

* Add support for linked modules (vuejs-templates#688)

* chore(package): rm unused lolex dependency(dev) (vuejs-templates#803)

* fix vuejs-templates#877

* Revert vuejs-templates#688, fix vuejs-templates#879

    We have to investigate how we can get vuejs-templates#688 work without the error reported in vuejs-templates#879

* revert: vuejs-templates#759

    That's actually not a good idea when you e.g. want to access the dev server from your mobile.

* - Re-added check for router
    - Modified eslint file to use standard and have M be a global

Approved-by: Jason Grubb <[email protected]>
c0defre4k added a commit to neonblack-at/webpack that referenced this issue Sep 13, 2017
@c0defre4k
Merge remote-tracking branch 'vuejs-templates/master'
62e7e60 
* vuejs-templates/master:
  Merge some small fixes (vuejs-templates#900)
  Update vue-loader link (vuejs-templates#886)
  match vue-template-compiler version
  revert: vuejs-templates#759
  Revert vuejs-templates#688, fix vuejs-templates#879
  fix vuejs-templates#877
  chore(package): rm unused lolex dependency(dev) (vuejs-templates#803)
  Add support for linked modules (vuejs-templates#688)
  add HashedModuleIdsPlugin when build (vuejs-templates#870)
  Specify the address to listen on (vuejs-templates#759)
  bump vue & vue-router dependencies
  fixed vue-router dependency(need vue-loader@^13.0.0) (vuejs-templates#876)
  Removing Vue.config.debug usage from documentation (vuejs-templates#871)
  fix ci build faild (vuejs-templates#857)
  fix standard eslint config link (vuejs-templates#834)
  Return exit code 1 when npm run build fails (vuejs-templates#854)
  load webpack.prod.conf when NODE_ENV=production (vuejs-templates#864)
  Remove unnecessary space and comma (vuejs-templates#866)
  Move Chat: Gitter -> Discord (vuejs-templates#869)

# Conflicts:
#	template/package.json
frandiox pushed a commit to OnsenUI/vue-cordova-webpack that referenced this issue Oct 13, 2017
@LinusBorg @frandiox
fix vuejs-templates#877
1866335
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lucidfrontier45 @LinusBorg