Move LImageOverlay url prop from mixin to component #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 21, 2021 22:53
|
Hi @mandryllo , thank you for these contributions! At first glance they look good to me, and I should have time to review them in more detail and merge them soon. In the meantime, I am curious if you believe this particular PR is still relevant, since it looks to me as if the changes it provides are already merged into the branches of your #683 and #684 PRs, so will be included once either or both of them are merged. Do you agree, or did I miss something about this one? |
|
@mikeu Yes, you are right, I opened this PR after those two but decided to merge it because I wanted to update their docs also 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves
LImageOverlayurlprop from mixin to a component so it doesn't end up in the components that inherit its mixin (likeLVideoOverlay#683 orLSVGOverlay#684 )If this PR is approved it should be merged before these two mentioned above because they depend on it.