Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fieldSelect.vue - noneSelected is not visible, required is not set #340

Closed
zoul0813 opened this issue Nov 9, 2017 · 0 comments · Fixed by #365
Closed

fieldSelect.vue - noneSelected is not visible, required is not set #340

zoul0813 opened this issue Nov 9, 2017 · 0 comments · Fixed by #365

Comments

@zoul0813
Copy link
Member

zoul0813 commented Nov 9, 2017

The "none selected" option is not "selected" by default, so the drop down appears empty.

Here's a JSFiddle, https://jsfiddle.net/zoul0813/ooncsad3/

The expectation is for the "Select One" text to appear in the dropdown if the user has not modified the dropdown value yet, the same way the "placeholder" attribute on input elements work. :selected="value == undefined" appears to not be working ... even though value is undefined.

fieldSelect.vue also does not set the "required" attribute on the select when schema.required is true.
@zoul0813 zoul0813 mentioned this issue Nov 30, 2017
Closed
zoul0813 added a commit to zoul0813/vue-form-generator that referenced this issue Dec 13, 2017
@zoul0813
fixes vue-generators#340 - "none" value set to null, formatValueToF…
5b42807 
…ield checks for `isNil(value)` and returns `null`, none options are always disabled

* updated tests to reflect "none is always disabled", could possibly be a selectOptions to allow users to select the "none" option to clear a previously selected value?
* added formatValueToField and return `null` when `isNil(value)`
@zoul0813 zoul0813 mentioned this issue Dec 13, 2017
Merged
zoul0813 added a commit that referenced this issue Dec 13, 2017
@zoul0813
Merge pull request #365 from zoul0813/feature/340-select-none
e678a72 
fixes #340
zoul0813 added a commit to zoul0813/vue-form-generator that referenced this issue Dec 13, 2017
@zoul0813
Merge branch 'master' into develop
19c4929 
* master:
  reverting back to original test
  reverted back to `schema.required` for "none selected" disabled state, per @icebob
  fixes vue-generators#340 - "none" value set to `null`, formatValueToField checks for `isNil(value)` and returns `null`, none options are always disabled
  fixes vue-generators#362 - `integer` validator now calls `number` validator, and returns `invalidIntegerl: "The value is not an integer"` as well as any errors generated by `number`
  fixes vue-generators#361 - use $event.target.valueAsNumber for number/range inputs, debounce `formatValueToModel` for number/range, removed `formatValueToField`
  added missing comma that failed in Travis
  requested by @icebob
  fixes vue-generators#341 - introduced debounce functionality into `formatValueToModel`

# Conflicts:
#	dist/vfg-core.js
#	dist/vfg.js
#	package-lock.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes #340 - "none" value set to null, formatValueToField checks fo… zoul0813/vue-form-generator
1 participant
@zoul0813