-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs & readme #123
Comments
I'm on it, but I don't think I will have the time to do everything |
OK, I can help you! |
Ok, I will inform you when I finished. Thank you ! |
I don't know how to handle the new hierarchy of fields.
OR Should we show what's in core vs optional:
I'm for the second option, since we explicitly say which dependency have each field in its description. |
I agree the second option. |
I have added this into the custom field page
I think we should encourage people to release their own custom field. Can we agree on a naming convention for vfg custom field ?
That would allow people to find other custom field easily. What do you think about that ? |
I prefer
|
Or |
I like your proposition. It keep the current naming convention used internally. |
I just realized that I don't know how to use the core version. // the normal way
import VueFormGenerator from "vue-form-generator"; I'm really confuse as to how this is going to work // the "core" way ???
import VueFormGenerator from "vue-form-generator/dist/vue-form-generator-core.js"; |
The code is correct, but ugly 😕 |
But this is the correct way. Like with Vue when you want to use the vue.common.js. Vue solution is you need to create an alias in webpack config |
Have you tested it ? |
Also, we never mention how to use the css file. |
Why not rename this to |
Yeah, like <style src="../../dist/vue-form-generator-core.css"></style> Good news is that it work, bad news is that it look bad with all the style in the dev environment.. |
Yeah |
@cristijora maybe an in-between with |
Hm, actually yeah. I think that one is the best option so far. |
Other solution is, we drop the dist folder and place bundles js & css to root of repo.
|
What is the problem with extracted CSS? I didn't find any problem. Please make a screenshot. |
@icebob I think I'm finished with the doc. Not everything is done, so I let you take a look. |
Sorry for late. I was ill. Thanks. I'll check it |
I checked, I think it's correct. I fix some examples and make some minor changes. |
Done |
After #120 we need to update docs & readme
The text was updated successfully, but these errors were encountered: