Update dataloader to 2.1.0 #1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 85ff4cb:
|
filipewl
approved these changes
Apr 22, 2022
There was a problem hiding this comment.
LGTM! Tested https://sfj-1586455--base.preview.vtex.app/ and all is still loading fine.
eduardoformiga
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
DataLoader used to rely on
setImmediateexisting on the browser which caused a lot of errors as reported on graphql/dataloader#249. This caused us to have an unwanted dependency on base.store. They issue has since been fixed in version 2.1.0. And we can get rid of it.
How to test it?
Test if the preview works as it should.
base.storeDeploy Previewhttps://preview-493--base.preview.vtex.app/