Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Legacy Editor warning appears even if Legacy Editor is disabled #71

Closed
arnaldop opened this issue Aug 7, 2022 · 5 comments
Closed
Labels
bug Something isn't working

Comments

@arnaldop
Copy link
Contributor

arnaldop commented Aug 7, 2022

Describe the bug

  1. I installed a new version of Obsidian with a brand new Vault.
  2. Legacy Editor Mode was disabled by default, because it is deprecated.
  3. Every time I open Obsidian, I get Zoom's warning about the legacy editor not being supported.

To Reproduce
Steps to reproduce the behavior:

  1. Install new Obsidian
  2. Create new Vault
  3. Install Zoom
  4. Restart Obsidian
  5. See warning, even though Obsidian disables legacy editor by default

Expected behavior
No warning if legacy editor is already disabled.

Desktop (please complete the following information):

  • OS: MacOS
  • Obsidian Version: 0.15.9
  • Plugin Version: 0.3.0
@arnaldop arnaldop added the bug Something isn't working label Aug 7, 2022
arnaldop added a commit to arnaldop/obsidian-zoom that referenced this issue Aug 7, 2022
@arnaldop
Copy link
Contributor Author

arnaldop commented Aug 7, 2022

PR #72

@vslinko vslinko changed the title Legacy Editor warning appears even if Legacy Editor is disabled [BUG] Legacy Editor warning appears even if Legacy Editor is disabled Aug 9, 2022
@vslinko vslinko moved this to Todo in vslinko's repos Aug 9, 2022
@lukemt
Copy link

lukemt commented Aug 10, 2022

Quick way to fix your installation: turn legacy editor on and off once. This will create the setting and make the warning go away. (The issue is otherwise the setting won't be present)

@arnaldop
Copy link
Contributor Author

Quick way to fix your installation: turn legacy editor on and off once. This will create the setting and make the warning go away. (The issue is otherwise the setting won't be present)

@lukemt, this is not at all good UX. Good UX would be to not alert the user about a condition that is possible, but is not present in the system, thus drawing attention to inner workings that might never play out as such.

In other words, I didn't know about legacy editors, TypeScript configs, etc., until I kept getting the same warning for a condition that I was sure was not occurring in my system.

Shorter words: Don't warn user about things they are not doing. (And the fix is not to tell a user to do something else to make the unnecessary warning go away.)

@lukemt
Copy link

lukemt commented Aug 10, 2022

Yeah true, just for now until a fix is available

arnaldop added a commit to arnaldop/obsidian-zoom that referenced this issue Aug 10, 2022
vslinko pushed a commit that referenced this issue Aug 14, 2022
* #71 - Legacy warning always appears.
@vslinko vslinko moved this from Todo to Done in vslinko's repos Aug 14, 2022
@vslinko
Copy link
Owner

vslinko commented Aug 14, 2022

@arnaldop @lukemt thank you all for your contributions. should be fixed in https://github.com/vslinko/obsidian-zoom/releases/tag/1.0.1

@vslinko vslinko closed this as completed Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

3 participants