-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Legacy Editor warning appears even if Legacy Editor is disabled #71
Comments
PR #72 |
Quick way to fix your installation: turn legacy editor on and off once. This will create the setting and make the warning go away. (The issue is otherwise the setting won't be present) |
@lukemt, this is not at all good UX. Good UX would be to not alert the user about a condition that is possible, but is not present in the system, thus drawing attention to inner workings that might never play out as such. In other words, I didn't know about legacy editors, TypeScript configs, etc., until I kept getting the same warning for a condition that I was sure was not occurring in my system. Shorter words: Don't warn user about things they are not doing. (And the fix is not to tell a user to do something else to make the unnecessary warning go away.) |
Yeah true, just for now until a fix is available |
@arnaldop @lukemt thank you all for your contributions. should be fixed in https://github.com/vslinko/obsidian-zoom/releases/tag/1.0.1 |
Describe the bug
To Reproduce
Steps to reproduce the behavior:
Expected behavior
No warning if legacy editor is already disabled.
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: