Handle rows with empty cells as non-empty lines #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vslinko
requested changes
Sep 20, 2023
reader.ts
Outdated
| @@ -189,6 +189,7 @@ export class CSVReader { | |||
| } | |||
|
|
|||
| private processColumn() { | |||
| this.emptyLine = false; | |||
There was a problem hiding this comment.
I think it's better to move this to line 362, right after this.debug("columnSeparator"); to keep this.emplyLine mutations within the same method.
|
@sekko27 Hi! Thank you for your contribution! Please fix linter issues and check my comment. |
vslinko
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for #23.
You manage the emptyLine state in CSVReader, but in case of column-separator presence this property should be set to false.
Test has been also added.