Add separate steps in GitHub action for snapshots and release builds #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goreleaser v4 GitHub action has completely removed support for automatically doing snapshot builds for commits which aren't associated with a tag. Since goreleaser's `--snapshot` doesn't have any smarts to do a non-snapshot build for commits which are tagged, we split the goreleaser step into separate steps for actions running against a tag and actions running against master.
bastjan
approved these changes
Dec 14, 2022
simu
added a commit
that referenced
this pull request
Dec 14, 2022
Despite my claim in #59, goreleaser does have logic to automatically enable snapshots for dirty commits. This commit reverts most of the changes from #59 and instead enables `--auto-snapshot`. Additionally, `goreleaser build` doesn't actually build the Linux packages, so it wasn't very useful in the first place.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The goreleaser v4 GitHub action has completely removed support for automatically doing snapshot builds for commits which aren't associated with a tag. Since goreleaser's
--snapshotdoesn't have any smarts to do a non-snapshot build for commits which are tagged, we split the goreleaser step into separate steps for actions running against a tag and actions running against master.Follow-up to #58
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog