Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also build artifacts for master #53

Merged
merged 2 commits into from
Nov 21, 2022
Merged

Also build artifacts for master #53

merged 2 commits into from
Nov 21, 2022

Conversation

glrf
Copy link
Contributor

@glrf glrf commented Nov 18, 2022

Summary

This should now lead to package builds on the master branch, allowing us to more easily test changes.

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog

@glrf glrf added the change label Nov 18, 2022
@glrf glrf self-assigned this Nov 18, 2022
@glrf glrf marked this pull request as ready for review November 21, 2022 12:28
@glrf glrf requested a review from a team November 21, 2022 12:28
Copy link
Member

@simu simu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we have some extra logic here to make sure we're not trying to create GitHub releases when the workflow is triggered by a push to master?

@glrf
Copy link
Contributor Author

glrf commented Nov 21, 2022

As far as I understand that magic is in goreleaser already and it only does it for a tag. At least when I tested it with this branch it did not generate a release

@glrf glrf merged commit f0684ac into master Nov 21, 2022
@glrf glrf deleted the change/release-master branch November 21, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants