Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CR-only line separator handling #335

Merged
merged 1 commit into from
Apr 12, 2019
Merged

Fix CR-only line separator handling #335

merged 1 commit into from
Apr 12, 2019

Conversation

Kijimuna
Copy link
Contributor

Fixes #334

- added support for CR-only line breaks (in addition to CRLF and
  LF-only line breaks)
- to accomplish that InlineParserImpl::parseNewLine() now looks ahead
  (does an LF follows a CR) instead of back (does a CR precedes an LF),
  which seems a good idea anyway, because we no longer need to repair
  preceding Text nodes (remove the surplus CR at the end)
@vsch
Copy link
Owner

vsch commented Apr 12, 2019

@Kijimuna, thank you for the fix. I will merge and make a release.

@vsch vsch merged commit bbe9bbf into vsch:master Apr 12, 2019
@vsch
Copy link
Owner

vsch commented Apr 12, 2019

Fix for this is available. Repo updated, maven updated but may take a while to show up in maven central.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CR line separators don’t produce line break nodes
2 participants