Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change URL of GitHub CDN #310

Merged
merged 1 commit into from
Feb 22, 2019
Merged

Change URL of GitHub CDN #310

merged 1 commit into from
Feb 22, 2019

Conversation

benelog
Copy link
Contributor

@benelog benelog commented Feb 22, 2019

The URL of Github CDN has changed from https://assets-cdn.github.com to https://github.githubassets.com/ . Old URLs return 404 (not found) now.

( For example : https://assets-cdn.github.com/images/icons/emoji/unicode/26a0.png?v7 -> https://github.githubassets.com/images/icons/emoji/unicode/26a0.png?v7 )

This PR fixes that problem.

@benelog
Copy link
Contributor Author

benelog commented Feb 22, 2019

A test is failed on master branch.

Failed tests:   testFullSpec(com.vladsch.flexmark.test.FullOrigSpecCoreTest): expected:<...``` ~~~(..)

Tests run: 3969, Failures: 1, Errors: 0, Skipped: 15

@vsch
Copy link
Owner

vsch commented Feb 22, 2019

@benelog, thank you for the PR, the failure is caused by me adding a new spec.txt from CommonMark before I implemented the changes to support it and then accidentally pushing my local changes to GitHub.

I'll merge and then fix the build.

@vsch vsch merged commit a82c83a into vsch:master Feb 22, 2019
@vsch
Copy link
Owner

vsch commented Feb 23, 2019

@benelog, repo updated and a new maven release is available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants