Skip to content

Commit

Permalink
pkg/registries: add a retiring note
Browse files Browse the repository at this point in the history
The registries package should be retired.  It was introduced as an
easier to use wrapper around c/image `sysregistries` which has been
replaced by `sysregistriesv2` a long while ago.

Users should either use the `sysregistriesv2` package directly or, even
better, we cache the config in libpod's image runtime to prevent
redundant (and ~expensive) parsing of the registries.conf files.

For now, just add a note in hope we'll not forgert about it when we find
time in the future.

Signed-off-by: Valentin Rothberg <[email protected]>
  • Loading branch information
vrothberg committed Sep 30, 2020
1 parent 4d57313 commit e930340
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions pkg/registries/registries.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
package registries

// TODO: this package should not exist anymore. Users should either use
// c/image's `sysregistriesv2` package directly OR, even better, we cache a
// config in libpod's image runtime so we don't need to parse the
// registries.conf files redundantly.

import (
"os"
"path/filepath"
Expand Down

0 comments on commit e930340

Please sign in to comment.