libpod API: pull: fix channel race

Fix a race condition in the pull endpoint caused by buffered channels. Using buffered channels can lead to the context's cancel function to be executed prior to the items being read from the channel. Fixes: containers#8870 Signed-off-by: Valentin Rothberg <[email protected]>
vrothberg · Jan 4, 2021 · acbec39 · acbec39
1 parent f261bfc
commit acbec39
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/pkg/api/handlers/libpod/images_pull.go b/pkg/api/handlers/libpod/images_pull.go
@@ -115,10 +115,10 @@ func ImagesPull(w http.ResponseWriter, r *http.Request) {
 		}
 	}
 
-	writer := channel.NewWriter(make(chan []byte, 1))
+	writer := channel.NewWriter(make(chan []byte))
 	defer writer.Close()
 
-	stderr := channel.NewWriter(make(chan []byte, 1))
+	stderr := channel.NewWriter(make(chan []byte))
 	defer stderr.Close()
 
 	images := make([]string, 0, len(imagesToPull))