DO NOT MERGE: test dropping loose digest lookups

Only for getting feedback from Podman and Buildah CI for now. See containers/issues/1248 for details. Signed-off-by: Valentin Rothberg <[email protected]>
vrothberg · Jun 14, 2023 · e521403 · e521403
1 parent 93be4a8
commit e521403
Showing 1 changed file with 21 additions and 19 deletions.
diff --git a/libimage/runtime.go b/libimage/runtime.go
@@ -437,25 +437,27 @@ func (r *Runtime) lookupImageInDigestsAndRepoTags(name string, options *LookupIm
 		return nil, "", fmt.Errorf("%s: %w", name, storage.ErrImageUnknown)
 	}
 
-	digested, isDigested := named.(reference.Digested)
-	if isDigested {
-		logrus.Debug("Looking for image with matching recorded digests")
-		digest := digested.Digest()
-		for _, image := range allImages {
-			for _, d := range image.Digests() {
-				if d != digest {
-					continue
-				}
-				// Also make sure that the matching image fits all criteria (e.g., manifest list).
-				if _, err := r.lookupImageInLocalStorage(name, image.ID(), options); err != nil {
-					return nil, "", err
-				}
-				return image, name, nil
-
-			}
-		}
-		return nil, "", fmt.Errorf("%s: %w", name, storage.ErrImageUnknown)
-	}
+// FIXME
+//
+//	digested, isDigested := named.(reference.Digested)
+//	if isDigested {
+//		logrus.Debug("Looking for image with matching recorded digests")
+//		digest := digested.Digest()
+//		for _, image := range allImages {
+//			for _, d := range image.Digests() {
+//				if d != digest {
+//					continue
+//				}
+//				// Also make sure that the matching image fits all criteria (e.g., manifest list).
+//				if _, err := r.lookupImageInLocalStorage(name, image.ID(), options); err != nil {
+//					return nil, "", err
+//				}
+//				return image, name, nil
+//
+//			}
+//		}
+//		return nil, "", fmt.Errorf("%s: %w", name, storage.ErrImageUnknown)
+//	}
 
 	if !shortnames.IsShortName(name) {
 		return nil, "", fmt.Errorf("%s: %w", name, storage.ErrImageUnknown)