Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Metallic-Smoothness with Occlusion texture with shader implementation. (faster!) #987

Merged
merged 6 commits into from
May 28, 2021

Conversation

Santarh
Copy link
Contributor

@Santarh Santarh commented May 27, 2021

#986 マージ後にレビューお願いします。

Import 時の Metallic-Smoothnes および Occlusion の合体テクスチャの実装を、CPU から GPU に置き換えました。
テストにて互換は確認しています。

以下の glTF-Sample-Models の Import において、 Texture の Import に 3 秒かかっていたのが 2 秒になりました。
https://github.com/KhronosGroup/glTF-Sample-Models/tree/master/2.0/FlightHelmet

@Santarh Santarh requested a review from ousttrue May 27, 2021 13:49
Copy link
Contributor

@ousttrue ousttrue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よさそう

@ousttrue ousttrue merged commit ff9a2cc into vrm-c:master May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants