空のモーフターゲットが出力されglTF違反になってしまうことがあるのを修正 #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlendShapeのindexずれ対策
|
PRいただいたバグフィックス saturday06#2 をマージしました。確認が足らず見落としてました。ありがとうございます 🙇 |
|
こちらこそ、空のmorphがあることをまったく想定していなかったのでありがとうございます 🙇 |
hiroj
approved these changes
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v0.56.3のデフォルトのエクスポート設定でglTF違反のデータを出力してしまうことがあるの修正しました。
こちらのVRM をUniVRM v0.56.3でインポートし、デフォルトの設定をいじらずエクスポートした結果の拡張子をglbとし、 https://github.khronos.org/glTF-Validator/ にかけた結果を次に示します。
変換前のVRMのエラーは0件です。残りの276件のエラーは、おそらくsparse accessorがデフォルトになった影響かと思いますが、今回は未調査です。