EditorTextureSerializer で例外になるテクスチャを事前にエラーメッセージにする #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ousttrue
commented
Jul 16, 2021
| { | ||
| case TextureImporterType.Default: | ||
| case TextureImporterType.NormalMap: | ||
| break; |
There was a problem hiding this comment.
EditorTextureSerializer はこの２種類しか対応していない
Santarh
previously approved these changes
Jul 16, 2021
| { | ||
| public virtual string GetGltfMaterialTypeFromUnityShaderName(string shaderName) | ||
| { | ||
| if (shaderName == "Standard") |
| using UnityEngine; | ||
|
|
||
| namespace UniGLTF | ||
| { | ||
| public interface IMaterialValidator |
There was a problem hiding this comment.
いまはこれでいいですが、このインタフェースは Validator だけの概念ではなく Exporter が参照すべきではありそう。
| switch (textureImporter.textureType) | ||
| { | ||
| case TextureImporterType.Default: | ||
| case TextureImporterType.NormalMap: |
There was a problem hiding this comment.
Exporter と Validator で2重に定義を持っていていいのかという感じはありますが、まあ Validator が厳しい分にはいいか…
There was a problem hiding this comment.
TODO: Validator(ExportDialog) と Exporter で同じ処理を共通化する
Exporter がテクスチャー列挙という形式をとらずに全部展開してするという手法を取っているため、それほど共通化されない。
あまりきれいにならず。 IMaterialValidator と IMaterialExporter は合体でいいかも。 |
というのが良かったか。 |
Santarh
approved these changes
Jul 16, 2021
|
Prepare, Validate, Export はたしかによさそう |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1100