Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test case for exporting nodes contains null mesh #1016

Merged
merged 1 commit into from
Jun 9, 2021

Conversation

oocytanb
Copy link
Contributor

@oocytanb oocytanb commented Jun 8, 2021

UniGLTF.gltfExporter のテストケースを追加しました。

MeshFilter のメッシュが null でマテリアルがある場合に、
MeshExportValidator はエクスポート可を返すにもかかわらず、
Mesh not found. 例外が発生します。

System.Exception : Mesh not found.
at UniGLTF.gltfExporter.ExportNode (UnityEngine.Transform x, System.Collections.Generic.List`1[T] nodes, System.Collections.Generic.List`1[T] meshWithRenderers, System.Collections.Generic.List`1[T] skins) [0x00128] in Assets/UniGLTF/Runtime/UniGLTF/IO/gltfExporter.cs:175 
  at UniGLTF.gltfExporter.Export (UniGLTF.MeshExportSettings meshExportSettings, VRMShaders.ITextureSerializer textureSerializer) [0x00272] in Assets/UniGLTF/Runtime/UniGLTF/IO/gltfExporter.cs:259 

Copy link
Contributor

@ousttrue ousttrue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ousttrue ousttrue merged commit 2b8568c into vrm-c:master Jun 9, 2021
@oocytanb oocytanb deleted the fix/test_for_exporting_null_mesh branch June 9, 2021 08:53
@ousttrue ousttrue mentioned this pull request Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants