Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CurrentUserPresence instanceType, platform, and status properties are now nullable strings #247

Merged
merged 6 commits into from
Jun 17, 2023
Merged

CurrentUserPresence instanceType, platform, and status properties are now nullable strings #247

merged 6 commits into from
Jun 17, 2023

Conversation

VinyarionHyarmendacil
Copy link
Contributor

as VRChat returns empty strings instead of undefined JSON properties, thereby complicating the schemas beyond what is necessary

@Foorack
Copy link
Member

Foorack commented Jun 13, 2023

As these enums are removed from here, are they used anywhere else? Can they be removed too?

@Foorack
Copy link
Member

Foorack commented Jun 13, 2023

Ah this is strictly under CurrentUserPrecense, which is a new object.

@Foorack Foorack requested a review from ariesclark June 13, 2023 04:47
@ariesclark ariesclark merged commit ec59ac0 into vrchatapi:main Jun 17, 2023
VinyarionHyarmendacil added a commit to VinyarionHyarmendacil/vrchatapi-specification that referenced this pull request Jan 18, 2024
@VinyarionHyarmendacil
Squashed commit of the following:
bf95930 
commit 0fa9f7a
Author: Vinyarion <[email protected]>
Date:   Thu Jan 18 12:06:18 2024 -0600

    Update CurrentUserPresence.yaml

commit ee62e4d
Author: Vinyarion <[email protected]>
Date:   Sat Jun 10 21:20:42 2023 -0500

    Change CurrentUserPresence instanceType and status properties to nullable string

commit e350518
Author: Aries <[email protected]>
Date:   Fri Jan 5 09:51:21 2024 -0700

    Update openapi.yaml (vrchatapi#269)

commit 2613589
Author: Miner28_3 <[email protected]>
Date:   Fri Jan 5 00:26:23 2024 +0100

    Group Search API (vrchatapi#268)

    * Group Search API

    * Fix Copy-Pasting issues

commit b461db3
Author: Aries <[email protected]>
Date:   Sat Dec 30 11:02:16 2023 -0700

    Release 1.16.0 (vrchatapi#267)

commit 4a87e10
Author: Miner28_3 <[email protected]>
Date:   Thu Dec 28 19:31:12 2023 +0100

    FIx UnityPackage nullable fields (vrchatapi#266)

commit 46aaca8
Author: Miner28_3 <[email protected]>
Date:   Wed Dec 27 18:11:00 2023 +0100

    Remove all regex patterns and Update API Fields (vrchatapi#264)

    * Update InstanceID, WorldID regex

    * Remove all regex patterns from schemas

    * Remove regex patterns from parameters

    * Add missing params to CurrentUser

    * Update UnityPackage

    * Update World and LimitedWorld (Add UdonProductId)

    * Remove last regex patterns

    ---------

    Co-authored-by: JU5TDIE <[email protected]>

commit 6484025
Author: Rexios <[email protected]>
Date:   Tue Oct 3 22:10:52 2023 -0400

    Release 1.15.0 (vrchatapi#261)

commit 0a25d5f
Author: Rexios <[email protected]>
Date:   Tue Oct 3 18:24:59 2023 -0400

    Don't require unity packages (vrchatapi#260)

commit bb6bdbb
Author: Rexios <[email protected]>
Date:   Thu Sep 21 00:40:39 2023 -0400

    Version bump (vrchatapi#258)

commit 968c565
Author: Rexios <[email protected]>
Date:   Thu Sep 21 00:07:39 2023 -0400

    Add group instance type (vrchatapi#257)

commit dc2cbe2
Author: Rexios <[email protected]>
Date:   Tue Sep 19 15:56:21 2023 -0400

    Bump version (vrchatapi#256)

commit 6f21fa8
Author: Miner28_3 <[email protected]>
Date:   Mon Sep 18 21:20:53 2023 +0200

    Update API Fields (vrchatapi#255)

    * Update LimitedUser to remove fallback

    * Add recommended capacity to world

    * Remove Min-max values from capacity fields

commit d1181fa
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Wed Jul 19 10:41:45 2023 +0200

    chore(deps): bump word-wrap from 1.2.3 to 1.2.4 (vrchatapi#252)

    Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4.
    - [Release notes](https://github.com/jonschlinkert/word-wrap/releases)
    - [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4)

    ---
    updated-dependencies:
    - dependency-name: word-wrap
      dependency-type: indirect
    ...

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit de800e0
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Thu Jul 13 14:20:30 2023 +0200

    chore(deps): bump semver from 5.7.1 to 5.7.2 (vrchatapi#251)

    Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2.
    - [Release notes](https://github.com/npm/node-semver/releases)
    - [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md)
    - [Commits](npm/node-semver@v5.7.1...v5.7.2)

    ---
    updated-dependencies:
    - dependency-name: semver
      dependency-type: indirect
    ...

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit ec59ac0
Author: Vinyarion <[email protected]>
Date:   Fri Jun 16 22:01:05 2023 -0500

    CurrentUserPresence instanceType, platform, and status properties are now nullable strings (vrchatapi#247)

    * Update schema CurrentUser, added schema CurrentUserPresence

    * Updated CurrentUserPresence properties referring to instances

    * Change CurrentUserPresence instanceType and status properties to nullable string

    * CurrentUserStatus properties inatanceType, platform, and status are now nullable strings

    as VRChat is returning empty strings instead of undefined properties

commit 21de7a6
Author: Vinyarion <[email protected]>
Date:   Sat Jun 10 17:42:24 2023 -0500

    Update schema CurrentUser, added schema CurrentUserPresence (vrchatapi#246)

    * Update schema CurrentUser, added schema CurrentUserPresence

    * Updated CurrentUserPresence properties referring to instances
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Foorack Foorack Foorack approved these changes

@ariesclark ariesclark Awaiting requested review from ariesclark

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VinyarionHyarmendacil @Foorack @ariesclark