Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notifications from the websocket have receiverUserId and do not have seen #193

Merged
merged 3 commits into from
Nov 29, 2022
Merged

Notifications from the websocket have receiverUserId and do not have seen #193

merged 3 commits into from
Nov 29, 2022

Conversation

Rexios80
Copy link
Collaborator

No description provided.

@Rexios80
Copy link
Collaborator Author

image

@Rexios80
Copy link
Collaborator Author

Are we going to merge this?

@Foorack
Copy link
Member

Foorack commented Nov 29, 2022

Are we going to merge this?

IIRC it was you who asked me to wait on this for you to do a little more testing. Can we merge it now?

@Foorack Foorack self-requested a review November 29, 2022 22:56
@Foorack Foorack self-assigned this Nov 29, 2022
@Foorack Foorack added Type: Enhancement This will **improve** existing or **add** something new Priority: Low Low priority, this has least priority to be fixed labels Nov 29, 2022
@Rexios80
Copy link
Collaborator Author

Oh. Yeah that testing is done.

@Foorack Foorack merged commit ed6735c into vrchatapi:main Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Foorack Foorack Foorack approved these changes

Assignees

@Foorack Foorack

Labels
Priority: Low Low priority, this has least priority to be fixed Type: Enhancement This will **improve** existing or **add** something new
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rexios80 @Foorack