Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notification details types aren't included #317

Closed
ttshivers opened this issue Apr 24, 2024 · 0 comments · Fixed by #318
Closed

Notification details types aren't included #317

ttshivers opened this issue Apr 24, 2024 · 0 comments · Fixed by #318

Comments

@ttshivers
Copy link
Contributor

The notification details types don't seem to be included in the bundle. These include NotificationDetailInvite, NotificationDetailInviteResponse, NotificationDetailRequestInvite, NotificationDetailRequestInviteResponse, NotificationDetailVoteToKick.

https://vrchatapi.github.io/docs/api/#get-/auth/user/notifications
ttshivers added a commit to ttshivers/specification that referenced this issue Apr 24, 2024
@ttshivers
fix(notifications): include the notification details schemas
96f84b6 
Include the notification details schemas manually since they aren't
referenced directly anywhere else.

Fixes: vrchatapi#317
ttshivers added a commit to ttshivers/specification that referenced this issue Apr 24, 2024
@ttshivers
fix(notifications): include the notification details schemas
b111b07 
Include the notification details schemas manually since they aren't
referenced directly anywhere else.

Fixes: vrchatapi#317
ttshivers added a commit to ttshivers/specification that referenced this issue Apr 24, 2024
@ttshivers
fix(notifications): include the notification details schemas
5efff96 
Include the notification details schemas manually since they aren't
referenced directly anywhere else.

Fixes: vrchatapi#317
@ttshivers ttshivers mentioned this issue Apr 24, 2024
Merged
ttshivers added a commit to ttshivers/specification that referenced this issue Apr 24, 2024
@ttshivers
fix(notifications): include the notification details schemas
ef4f957 
Include the notification details schemas manually since they aren't
referenced directly anywhere else.

Fixes: vrchatapi#317
ariesclark pushed a commit that referenced this issue Apr 24, 2024
@ttshivers
fix(notification): Include notification details (#318)
1b8686b 
* build(deps): update to @redocly/cli

Update to @redocly/cli which replaces @redocly/openapi-cli.
https://www.npmjs.com/package/@redocly/openapi-cli

This is necessary to bring in fixes for the bundler not properly
including refs when adding extra schemas.

* fix(notifications): include the notification details schemas

Include the notification details schemas manually since they aren't
referenced directly anywhere else.

Fixes: #317

* lint: add ignore for unused component

Add ignore for unused component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(notification): Include notification details ttshivers/specification
1 participant
@ttshivers