Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Bakery Lightmapper light types #31

Merged
merged 8 commits into from
Mar 5, 2024

Conversation

arranash
Copy link
Contributor

@arranash arranash commented Mar 2, 2024

Added Bakery types, added bakery to assembly definition

arranash added 4 commits March 2, 2024 15:24
Types now check for bakery in project, prevents errors if bakery not in project
Added bakery to assembly definition or else cannot be seen
Renamed types to better fit format
@arranash
Copy link
Contributor Author

arranash commented Mar 2, 2024

This is my first pull request, apologies if I've made mistakes.
I've tested in an empty 2022 VRChat project, it creates no errors when bakery isn't installed and works when bakery is installed.

@arranash arranash changed the title Master Added Bakery Lightmapper light types Mar 2, 2024
@JordoVR JordoVR changed the base branch from vpm to 1.4.0 March 5, 2024 04:27
Copy link

github-actions bot commented Mar 5, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@JordoVR
Copy link
Collaborator

JordoVR commented Mar 5, 2024

I have read the CLA Document and I hereby sign the CLA

@JordoVR
Copy link
Collaborator

JordoVR commented Mar 5, 2024

I took the liberty of merging the VPM branch as this is the branch we're using moving forward, this looks promising, might add it to 1.4.0 (that coincidentally is Bakery related)

@JordoVR JordoVR merged commit 6edb322 into vrchat-community:1.4.0 Mar 5, 2024
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2024
@JordoVR
Copy link
Collaborator

JordoVR commented Mar 5, 2024

Thank you! Included in 1.4.0 barring no issues while testing! :D

@arranash arranash deleted the master branch March 5, 2024 12:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants