Add WSDL xmlns header attribute (#1093)

* Update client.ts * Add xmlnsInHeader attribute * Add missing whitespace * Do not modify the initial header options Since I've modified the initial spec of the package, the tests will fail * Add custom client test for user defined header arguments * Add custom client test for user defined header arguments
vpulim · Nov 5, 2019 · af93a6f · af93a6f
1 parent 6b5ba3e
commit af93a6f
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 1 deletion.
diff --git a/src/client.ts b/src/client.ts
@@ -409,7 +409,7 @@ export class Client extends EventEmitter {
       this.wsdl.xmlnsInEnvelope + '>' +
       ((decodedHeaders || this.security) ?
         (
-          '<' + envelopeKey + ':Header>' +
+          '<' + envelopeKey + ':Header' + (this.wsdl.xmlnsInHeader ? (' ' + this.wsdl.xmlnsInHeader) : '') + '>' +
           (decodedHeaders ? decodedHeaders : '') +
           (this.security && !this.security.postProcess ? this.security.toXML() : '') +
           '</' + envelopeKey + ':Header>'

diff --git a/src/wsdl/index.ts b/src/wsdl/index.ts
@@ -70,6 +70,7 @@ export class WSDL {
   public valueKey = '$value';
   public xmlKey = '$xml';
   public xmlnsInEnvelope: string;
+  public xmlnsInHeader: string;
   public uri: string;
   public definitions: elements.DefinitionsElement;
   public options: IInitializedOptions;

diff --git a/test/client-test.js b/test/client-test.js
@@ -1537,6 +1537,20 @@ var fs = require('fs'),
   });
 });
 
+it('shall generate correct header for custom defined header arguments', function(done) {
+  soap.createClientAsync(__dirname + '/wsdl/default_namespace.wsdl').then(function (client) {
+    client.addSoapHeader('test-header-namespace')
+    client.wsdl.xmlnsInHeader = 'xmlns="https://example.com/v1"';
+    var expectedDefinedHeader = '<soap:Header xmlns="https://example.com/v1">';
+
+    client.MyOperation(function(err, result, rawResponse, soapHeader, rawRequest) {
+      var definedSoapHeader = client.lastRequest.match(/<soap:Header xmlns=("(.*?)">)/)[0];
+      assert.ok(definedSoapHeader === expectedDefinedHeader);
+      done();
+    });
+  });
+});
+
 it('should create async client without options', function (done) {
   soap.createClientAsync(__dirname + '/wsdl/default_namespace.wsdl').then(function (client) {
     assert.ok(client);