Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new COM Version method including build number as double #249

Open
JockeJarre opened this issue Mar 11, 2024 · 7 comments
Open

Add new COM Version method including build number as double #249

JockeJarre opened this issue Mar 11, 2024 · 7 comments

Comments

@JockeJarre
Copy link
Contributor

Similar to the issue on VPX: vpinball/vpinball#1558

Is your feature request related to a problem? Please describe.
To help the flipper table creators, not having to tell in all forums which minimum version to use for VPX, VPM and B2S

Describe the solution you'd like
Currently the Version method returns a string as "03060000" for VPM 3.6, it would be an improvement if the build number would be added as decimal value like "03060000.0879" (allowing 4 decimal characters), meaning one would have to change the method to return a bigger string instead.

Describe alternatives you've considered
I have been thinking of using a separate Version method. But rather I would keep the same. I also considered changing the datatype to double as in VPX, but then a lot of scripts and tables would have to be changed.

Additional context
I have tested the current usage of controller.FullVersion in the local vbs files, and the same if statements still work perfect.

Some examples from "core.vbs":

  1. If Controller.Version >= "01200000" Then
  2. If Controller.Version >= 03060000 Then one note, the correct usage would be to use "03060000" comparing two strings!

Using this it will be possible to test using the build number as decimal:

  1. Controller.Version >= 03060000.0879 is True (where Controller.Version is a string with value "03060000.0880")

The same also works in older versions

  1. Controller.Version >= "03060000.0879" is False (where Controller.Version is an string with value "03060000")
@toxieainc
Copy link
Member

@JockeJarre While at it, seems i screwed up the actions via my additional version changes.
But i don't get it, as things build locally for me.
Could you please check a4a9c22 what i did wrong? Thanks!

@JockeJarre
Copy link
Contributor Author

Will do!

@JockeJarre
Copy link
Contributor Author

I found out what the problem is. I have reverted src/version.c for now.
The workflow tasks are reading out the "3.6" from version.c and build version strings from that.

I will clean it up within this issue and put your changes in.
I do not think I can push directly to this repo, so I will make a pull request.

@JockeJarre
Copy link
Contributor Author

JockeJarre commented Mar 12, 2024

@toxieainc Do you know if and how to add sourcecode to the *_VC20XX.vcxproj.filters and *_VC20XX.vcxproj.filters files?
Is there any common logic to follow, when new files are added? I think I added something wrong in last issue which got merged.

@toxieainc
Copy link
Member

Will look into it..

@toxieainc
Copy link
Member

The vcproj files were good, just a tiny quirk with the .rc file..

JockeJarre added a commit to JockeJarre/pinmame that referenced this issue Mar 14, 2024
@JockeJarre
Copy link
Contributor Author

I have made the changes with adding build number to the COM methods VP + VPM. (both in forks)
Will let it settle a little and use these versions for the next couple of days...

@JockeJarre JockeJarre changed the title Add build number to the COM Version method of VPM Add new COM Version method including build number as double Jul 19, 2024
JockeJarre added a commit to JockeJarre/pinmame that referenced this issue Jul 19, 2024
JockeJarre added a commit to JockeJarre/pinmame that referenced this issue Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants