-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new COM Version method including build number as double #249
Comments
@JockeJarre While at it, seems i screwed up the actions via my additional version changes. |
Will do! |
I found out what the problem is. I have reverted src/version.c for now. I will clean it up within this issue and put your changes in. |
@toxieainc Do you know if and how to add sourcecode to the *_VC20XX.vcxproj.filters and *_VC20XX.vcxproj.filters files? |
Will look into it.. |
The vcproj files were good, just a tiny quirk with the .rc file.. |
I have made the changes with adding build number to the COM methods VP + VPM. (both in forks) |
Similar to the issue on VPX: vpinball/vpinball#1558
Is your feature request related to a problem? Please describe.
To help the flipper table creators, not having to tell in all forums which minimum version to use for VPX, VPM and B2S
Describe the solution you'd like
Currently the Version method returns a string as "03060000" for VPM 3.6, it would be an improvement if the build number would be added as decimal value like "03060000.0879" (allowing 4 decimal characters), meaning one would have to change the method to return a bigger string instead.
Describe alternatives you've considered
I have been thinking of using a separate Version method. But rather I would keep the same. I also considered changing the datatype to double as in VPX, but then a lot of scripts and tables would have to be changed.
Additional context
I have tested the current usage of controller.FullVersion in the local vbs files, and the same if statements still work perfect.
Some examples from "core.vbs":
Using this it will be possible to test using the build number as decimal:
The same also works in older versions
The text was updated successfully, but these errors were encountered: