Flipper issues on WOF (was: Lamps above 400 on Wheel of Fortune) #196

francisdb · 2024-01-18T08:54:37Z

First, is there a better place to ask these questions?

This table used to play without issues but Controller.ChangedLamps now seems to return lamps over 400 where the table code has only 400 entries in the arrays. Is this expected as it might break more tables?

2024-01-18 09:46:07.837 INFO  [28830] [DebuggerModule::Print@4232] Script.Print 'lamp 580 state 255'
2024-01-18 09:46:07.847 INFO  [28830] [DebuggerModule::Print@4232] Script.Print 'lamp 583 state 255'
2024-01-18 09:46:07.866 INFO  [28830] [DebuggerModule::Print@4232] Script.Print 'lamp 581 state 255'
2024-01-18 09:46:07.886 INFO  [28830] [DebuggerModule::Print@4232] Script.Print 'lamp 582 state 255'
2024-01-18 09:46:11.757 INFO  [28830] [DebuggerModule::Print@4232] Script.Print 'lamp 580 state 0'
2024-01-18 09:46:11.788 INFO  [28830] [DebuggerModule::Print@4232] Script.Print 'lamp 583 state 0'
2024-01-18 09:46:11.916 INFO  [28830] [DebuggerModule::Print@4232] Script.Print 'lamp 581 state 0'
2024-01-18 09:46:12.167 INFO  [28830] [DebuggerModule::Print@4232] Script.Print 'lamp 582 state 0'
2024-01-18 09:46:40.307 INFO  [28830] [DebuggerModule::Print@4232] Script.Print 'lamp 601 state 0'
2024-01-18 09:46:36.137 INFO  [28830] [DebuggerModule::Print@4232] Script.Print 'lamp 609 state 255'
2024-01-18 09:46:40.317 INFO  [28830] [DebuggerModule::Print@4232] Script.Print 'lamp 595 state 247'
2024-01-18 09:46:40.338 INFO  [28830] [DebuggerModule::Print@4232] Script.Print 'lamp 595 state 121'
2024-01-18 09:46:40.357 INFO  [28830] [DebuggerModule::Print@4232] Script.Print 'lamp 588 state 0'

PINMAME_SHA beec0c3

The text was updated successfully, but these errors were encountered:

vbousquet · 2024-01-19T08:53:11Z

This is intended and is only for WOF and WPT. It happens that these tables have LED matrices which seem to be PWMed so I added them as such.

francisdb · 2024-01-19T09:21:09Z

Ok, I guess it's then up to the table writers to account for these new lamps.

For reference the required diff to fix this (along with some other standalone fixes)

--- "Wheel of Fortune (Stern 2007) 1.0.vbs.original.tmp"        2024-01-19 10:24:05.222749595 +0100
+++ "Wheel of Fortune (Stern 2007) 1.0.vbs"     2024-01-19 10:23:58.334543589 +0100
@@ -10,6 +10,8 @@
 If Err Then MsgBox "You need the controller.vbs in order to run this table, available in the vp10 package"
 On Error Goto 0
 
+Const cGameName = "wof_500"
+
 Const Ballsize = 52
 Const BallMass = 1.5
 
@@ -43,8 +45,6 @@
 '                                               INIT TABLE
 '************************************************************************
 
-Const cGameName = "wof_500"
-
 Dim bsTrough, PlungerIM, DTBank
 
 Sub Table1_Init
@@ -567,8 +567,8 @@
 ' SetLamp 1 is On
 ' fading for non opacity objects is 4 steps
 '***************************************************
-Dim LampState(400), FadingLevel(400)
-Dim FlashSpeedUp(400), FlashSpeedDown(400), FlashMin(400), FlashMax(400), FlashLevel(400)
+Dim LampState(610), FadingLevel(610)
+Dim FlashSpeedUp(610), FlashSpeedDown(610), FlashMin(610), FlashMax(610), FlashLevel(610)
 
 InitLamps()             ' turn off the lights and flashers and reset them to the default parameters
 LampTimer.Interval = 10 'lamp fading speed
@@ -913,7 +913,7 @@
 
 Function Vol(ball) ' Calculates the Volume of the sound based on the ball speed
     Vol = Csng(BallVel(ball) ^2 / 5000)
-       Debug.Print Vol
+       'Debug.Print Vol
 End Function
 
 Function Pan(ball) ' Calculates the pan for a ball based on the X position on the table. "table1" is the name of the table

toxieainc · 2024-01-20T12:46:05Z

@vbousquet Is this something that should also be added to the whatsnew?

toxieainc · 2024-01-29T21:48:54Z

Sidenote: As mentioned above, a similar patch is needed for WPT.

francisdb · 2024-02-06T08:24:17Z

@vbousquet I also have issues with the flippers on WOF, sometimes they don't react or are stuck in the up position. Looks like some events get lost. Does that ring a bell?

toxieainc · 2024-02-06T16:46:30Z

Is this with 10.8.0 or 10.8.1?

francisdb · 2024-02-06T17:49:12Z

For now I can only reproduce it on standalone branch or 10.8.1 standalone, works fine on windows. And only for this table which is strange.

jsm174 · 2024-02-06T18:06:59Z

Your windows pinmame is on the absolute latest?

francisdb · 2024-02-06T18:52:12Z

Latest pre-release vpinmame downloaded yesterday.

francisdb · 2024-02-06T19:27:01Z

Can I test this in xpinmame without table?

jsm174 · 2024-02-06T19:45:50Z

I'm at a loss, as to why this only a standalone issue. libpinmame is not doing anything to the data. (it was previously to support RGBs with VPE, but all that was reverted). Its running through all the same code as the win32com.

Maybe I missed a core_request_pwm_output_update();

Maybe a second set of eyes could compare:

pinmame/src/libpinmame/libpinmame.cpp

Lines 1008 to 1189 in 699fabc

    
           PINMAMEAPI uint32_t PinmameGetSolenoidMask(const int low) 
        
           { 
        
           	return vp_getSolMask(low); 
        
           } 
        
           /****************************************************** 
        
            * PinmameSetSolenoidMask 
        
            ******************************************************/ 
        
           PINMAMEAPI void PinmameSetSolenoidMask(const int low, const uint32_t mask) 
        
           { 
        
           	vp_setSolMask(low, mask); 
        
           } 
        
           /****************************************************** 
        
            * PinmameGetModOutputType 
        
            ******************************************************/ 
        
           PINMAMEAPI PINMAME_MOD_OUTPUT_TYPE PinmameGetModOutputType(const int output, const int no) 
        
           { 
        
           	return (PINMAME_MOD_OUTPUT_TYPE)vp_getModOutputType(output, no); 
        
           } 
        
           /****************************************************** 
        
            * PinmameSetModOutputType 
        
            ******************************************************/ 
        
           PINMAMEAPI void PinmameSetModOutputType(const int output, const int no, const PINMAME_MOD_OUTPUT_TYPE type) 
        
           { 
        
           	vp_setModOutputType(output, no, (int)type); 
        
           } 
        
           /****************************************************** 
        
            * PinmameGetMaxSolenoids 
        
            ******************************************************/ 
        
           PINMAMEAPI int PinmameGetMaxSolenoids() 
        
           { 
        
           	return CORE_MODOUT_SOL_MAX; 
        
           } 
        
           /****************************************************** 
        
            * PinmameGetSolenoid 
        
            ******************************************************/ 
        
           PINMAMEAPI int PinmameGetSolenoid(const int solNo) 
        
           { 
        
           	if (!_isRunning) 
        
           		return 0; 
        
           	core_request_pwm_output_update(); 
        
           	return vp_getSolenoid(solNo); 
        
           } 
        
           /****************************************************** 
        
            * PinmameGetChangedSolenoids 
        
            ******************************************************/ 
        
           PINMAMEAPI int PinmameGetChangedSolenoids(PinmameSolenoidState* const p_changedStates) 
        
           { 
        
           	if (!_isRunning) 
        
           		return -1; 
        
           	core_request_pwm_output_update(); 
        
           	vp_tChgSols chgSols; 
        
           	const int count = vp_getChangedSolenoids(chgSols); 
        
           	if (count > 0) 
        
           		memcpy(p_changedStates, chgSols, count * sizeof(PinmameSolenoidState)); 
        
           	return count; 
        
           } 
        
           /****************************************************** 
        
            * PinmameGetMaxLamps 
        
            ******************************************************/ 
        
           PINMAMEAPI int PinmameGetMaxLamps() 
        
           { 
        
           	return CORE_MODOUT_LAMP_MAX; 
        
           } 
        
           /****************************************************** 
        
            * PinmameGetLamp 
        
            ******************************************************/ 
        
           PINMAMEAPI int PinmameGetLamp(const int lampNo) 
        
           { 
        
           	if (!_isRunning) 
        
           		return 0; 
        
           	core_request_pwm_output_update(); 
        
           	return vp_getLamp(lampNo); 
        
           } 
        
           /****************************************************** 
        
            * PinmameGetChangedLamps 
        
            ******************************************************/ 
        
           PINMAMEAPI int PinmameGetChangedLamps(PinmameLampState* const p_changedStates) 
        
           { 
        
           	if (!_isRunning) 
        
           		return -1; 
        
           	core_request_pwm_output_update(); 
        
           	vp_tChgLamps chgLamps; 
        
           	const int count = vp_getChangedLamps(chgLamps); 
        
           	if (count > 0) 
        
           		memcpy(p_changedStates, chgLamps, count * sizeof(PinmameLampState)); 
        
           	return count; 
        
           } 
        
           /****************************************************** 
        
            * PinmameGetMaxGIs 
        
            ******************************************************/ 
        
           PINMAMEAPI int PinmameGetMaxGIs() 
        
           { 
        
           	return CORE_MODOUT_GI_MAX; 
        
           } 
        
           /****************************************************** 
        
            * PinmameGetGI 
        
            ******************************************************/ 
        
           PINMAMEAPI int PinmameGetGI(const int giNo) 
        
           { 
        
           	if (!_isRunning) 
        
           		return 0; 
        
           	core_request_pwm_output_update(); 
        
           	return vp_getGI(giNo); 
        
           } 
        
           /****************************************************** 
        
            * PinmameGetChangedGIs 
        
            ******************************************************/ 
        
           PINMAMEAPI int PinmameGetChangedGIs(PinmameGIState* const p_changedStates) 
        
           { 
        
           	if (!_isRunning) 
        
           		return -1; 
        
           	core_request_pwm_output_update(); 
        
           	vp_tChgGIs chgGIs; 
        
           	const int count = vp_getChangedGI(chgGIs); 
        
           	if (count > 0) 
        
           		memcpy(p_changedStates, chgGIs, count * sizeof(PinmameGIState)); 
        
           	return count; 
        
           } 
        
           /****************************************************** 
        
            * PinmameGetMaxLEDs 
        
            ******************************************************/ 
        
           PINMAMEAPI int PinmameGetMaxLEDs() 
        
           { 
        
           	return CORE_MODOUT_SEG_MAX; 
        
           } 
        
           /****************************************************** 
        
            * PinmameGetChangedLEDs 
        
            ******************************************************/ 
        
           PINMAMEAPI int PinmameGetChangedLEDs(const uint64_t mask, const uint64_t mask2, PinmameLEDState* const p_changedStates) 
        
           { 
        
           	if (!_isRunning) 
        
           		return -1; 
        
           	core_request_pwm_output_update(); 
        
           	vp_tChgLED chgLEDs; 
        
           	const int count = vp_getChangedLEDs(chgLEDs, mask, mask2); 
        
           	if (count > 0) 
        
           		memcpy(p_changedStates, chgLEDs, count * sizeof(PinmameLEDState)); 
        
           	return count; 
        
           }

to

pinmame/src/win32com/Controller.cpp

Lines 1459 to 1733 in 699fabc

    
           /************************************************************************** 
        
            * IController.GIString property (read-only): returns state of a GI String 
        
            **************************************************************************/ 
        
           STDMETHODIMP CController::get_GIString(int nString, int *pVal) { 
        
             if (!pVal) return S_FALSE; 
        
             if (WaitForSingleObject(m_hEmuIsRunning, 0) == WAIT_TIMEOUT) 
        
               *pVal = 0; 
        
             else { 
        
               core_request_pwm_output_update(); 
        
               *pVal = vp_getGI(nString); 
        
             } 
        
             return S_OK; 
        
           } 
        
           /*************************************************************** 
        
            * IController.ChangedGIString property: returns a list of the  
        
            * numbers of GIStrings which state has changed since the last call 
        
            * number is in the first, state in the second part 
        
            ***************************************************************/ 
        
           STDMETHODIMP CController::get_ChangedGIStrings(VARIANT *pVal) { 
        
             vp_tChgGIs chgGI; 
        
             if (!pVal) return S_FALSE; 
        
             if (WaitForSingleObject(m_hEmuIsRunning, 0) == WAIT_TIMEOUT) 
        
               { pVal->vt = 0; return S_OK; } 
        
             /*-- Request an update that will be processed asynchronously --*/ 
        
             core_request_pwm_output_update(); 
        
             int uCount = vp_getChangedGI(chgGI); 
        
             if (uCount == 0) 
        
               { pVal->vt = 0; return S_OK; } 
        
             /*-- Create array --*/ 
        
             SAFEARRAYBOUND Bounds[] = {{(ULONG)uCount,0}, {2,0}}; 
        
             SAFEARRAY *psa = SafeArrayCreate(VT_VARIANT, 2, Bounds); 
        
             long ix[2]; 
        
             VARIANT GIState; 
        
             GIState.vt = VT_I4; 
        
             /*-- add changed to array --*/ 
        
             for (ix[0] = 0; ix[0] < uCount; ix[0]++) { 
        
               ix[1] = 0; // GI Number 
        
               GIState.lVal = chgGI[ix[0]].giNo; 
        
               SafeArrayPutElement(psa, ix, &GIState); 
        
               ix[1] = 1; // GI status 
        
               GIState.lVal = chgGI[ix[0]].currStat; 
        
               SafeArrayPutElement(psa, ix, &GIState); 
        
             } 
        
             pVal->vt = VT_ARRAY | VT_VARIANT; 
        
             pVal->parray = psa; 
        
             return S_OK; 
        
           } 
        
           /**************************************************************************** 
        
            * IController.ChangedSolenoids property (read-only): gets the state of all  
        
            * solenoids 
        
            * (also gets the information, if at least one solenoid has changed after  
        
            * last call; element 0 state if TRUE if at least one solenoid has changed  
        
            * state sice last call) 
        
            ****************************************************************************/ 
        
           STDMETHODIMP CController::get_ChangedSolenoids(VARIANT *pVal) 
        
           { 
        
             vp_tChgSols chgSol; 
        
             if (!pVal) return S_FALSE; 
        
             if (WaitForSingleObject(m_hEmuIsRunning, 0) == WAIT_TIMEOUT) 
        
           	{ pVal->vt = 0; return S_OK; } 
        
             /*-- Request an update that will be processed asynchronously --*/ 
        
             core_request_pwm_output_update(); 
        
             /*-- Count changed solenoids --*/ 
        
             int uCount = vp_getChangedSolenoids(chgSol); 
        
             if (uCount == 0) 
        
           	{ pVal->vt = 0; return S_OK; } 
        
             /*-- Create array --*/ 
        
             SAFEARRAYBOUND Bounds[] = {{(ULONG)uCount,0}, {2,0}}; 
        
             SAFEARRAY *psa = SafeArrayCreate(VT_VARIANT, 2, Bounds); 
        
             long ix[2]; 
        
             VARIANT varValue; 
        
             varValue.vt = VT_I4; 
        
             /*-- add changed solenoids to the array --*/ 
        
             for (ix[0] = 0; ix[0] < uCount; ix[0]++) { 
        
           	ix[1] = 0; // Solenoid number 
        
           	varValue.lVal = chgSol[ix[0]].solNo; 
        
           	SafeArrayPutElement(psa, ix, &varValue); 
        
           	ix[1] = 1; // Solenoid status 
        
           	varValue.lVal = chgSol[ix[0]].currStat; 
        
           	SafeArrayPutElement(psa, ix, &varValue); 
        
             } 
        
             pVal->vt = VT_ARRAY | VT_VARIANT; 
        
             pVal->parray = psa; 
        
             return S_OK; 
        
           } 
        
           /**************************************************************************** 
        
            * IController.SplashInfoLine property: sets the value of the user setable  
        
            * text in the splash screen 
        
            ****************************************************************************/ 
        
           STDMETHODIMP CController::get_SplashInfoLine(BSTR *pVal) 
        
           { 
        
           	CComBSTR strValue(m_szSplashInfoLine); 
        
           	*pVal = strValue.Detach(); 
        
           	return S_OK; 
        
           } 
        
           STDMETHODIMP CController::put_SplashInfoLine(BSTR newVal) 
        
           { 
        
           	WideCharToMultiByte(CP_ACP, 0, newVal, -1, m_szSplashInfoLine, sizeof m_szSplashInfoLine, NULL, NULL); 
        
           	return S_OK; 
        
           } 
        
           /**************************************************************************** 
        
            * IController.Solenoids property (read-only): returns the state of all  
        
            * solenoids at once 
        
            ****************************************************************************/ 
        
           STDMETHODIMP CController::get_Solenoids(VARIANT *pVal) 
        
           { 
        
           	if ( !pVal ) 
        
           		return S_FALSE; 
        
           	/*-- Request an update that will be processed asynchronously --*/ 
        
           	core_request_pwm_output_update(); 
        
           	SAFEARRAY *psa = SafeArrayCreateVector(VT_VARIANT, 0, 65); 
        
           	VARIANT* pData; 
        
           	SafeArrayAccessData(psa, (void**)&pData); 
        
           	const bool timeout = (WaitForSingleObject(m_hEmuIsRunning, 0) == WAIT_TIMEOUT); 
        
           	for (int i = 0; i < 65; ++i) 
        
           	{ 
        
           		pData[i].vt = VT_BOOL; 
        
           		pData[i].boolVal = timeout ? VARIANT_FALSE : (vp_getSolenoid(i) ? VARIANT_TRUE : VARIANT_FALSE); 
        
           	} 
        
           	SafeArrayUnaccessData(psa); 
        
           	pVal->vt = VT_ARRAY|VT_VARIANT; 
        
           	pVal->parray = psa; 
        
           	return S_OK; 
        
           } 
        
           /**************************************************************************** 
        
            * IController.Dip property: gets/sets the value of a dip bank 
        
            ****************************************************************************/ 
        
           STDMETHODIMP CController::get_Dip(int nNo, int *pVal) 
        
           { 
        
           	// TODO: Add your implementation code here. DONE 
        
           	if (!pVal) return S_FALSE; 
        
           	*pVal = vp_getDIP(nNo); 
        
           	return S_OK; 
        
           } 
        
           STDMETHODIMP CController::put_Dip(int nNo, int newVal) 
        
           { 
        
           	// TODO: Add your implementation code here. DONE 
        
           	vp_setDIP(nNo, newVal); 
        
           	return S_OK; 
        
           } 
        
           /**************************************************************************** 
        
            * IController.GIStrings property (read-only): gets the value of all GI  
        
            * strings at once 
        
            ****************************************************************************/ 
        
           STDMETHODIMP CController::get_GIStrings(VARIANT *pVal) 
        
           { 
        
           	if ( !pVal ) 
        
           		return S_FALSE; 
        
           	/*-- Request an update that will be processed asynchronously --*/ 
        
           	core_request_pwm_output_update(); 
        
           	SAFEARRAY *psa = SafeArrayCreateVector(VT_VARIANT, 0, CORE_MAXGI); 
        
           	VARIANT* pData; 
        
           	SafeArrayAccessData(psa, (void**)&pData); 
        
           	const bool timeout = (WaitForSingleObject(m_hEmuIsRunning, 0) == WAIT_TIMEOUT); 
        
           	for (int i = 0; i < CORE_MAXGI; ++i) 
        
           	{ 
        
           		pData[i].vt = VT_I4; 
        
           		pData[i].lVal = timeout ? 0 : vp_getGI(i); 
        
           	} 
        
           	SafeArrayUnaccessData(psa); 
        
           	pVal->vt = VT_ARRAY|VT_VARIANT; 
        
           	pVal->parray = psa; 
        
           	return S_OK; 
        
           } 
        
           /**************************************************************************** 
        
            * IController.LockDisplay property: If the display is locked, anytime the 
        
            * video window will receive the focus the focus will immediatly be returned 
        
            * to the window which had it before 
        
            ****************************************************************************/ 
        
           STDMETHODIMP CController::get_LockDisplay(VARIANT_BOOL *pVal) 
        
           { 
        
           	if (pVal) 
        
           		*pVal = m_fDisplayLocked?VARIANT_TRUE:VARIANT_FALSE; 
        
           	return S_OK; 
        
           } 
        
           STDMETHODIMP CController::put_LockDisplay(VARIANT_BOOL newVal) 
        
           { 
        
           	m_fDisplayLocked = newVal; 
        
           	return S_OK; 
        
           } 
        
           /**************************************************************************** 
        
            * IController.SolMask property: gets/sets a mask for the solenoids, i.e.  
        
            * which solenoid state should be reported by ChangedSolenoids 
        
            ****************************************************************************/ 
        
           STDMETHODIMP CController::get_SolMask(int nLow, long *pVal) 
        
           { 
        
           	if ( !pVal) 
        
           		return S_FALSE; 
        
           	*pVal = vp_getSolMask(nLow); 
        
           	return S_OK; 
        
           } 
        
           STDMETHODIMP CController::put_SolMask(int nLow, long newVal) 
        
           { 
        
           	// TODO B2S hack, see vp_setSolMask() 
        
           	if (!((0 <= nLow && nLow <= 2) || (1000 <= nLow && nLow < 2999))) 
        
           		return S_FALSE; 
        
           	vp_setSolMask(nLow, newVal); 
        
           	return S_OK; 
        
           } 
        
           /**************************************************************************** 
        
            * IController.ModOutputType property: gets/sets modulated output type, i.e. 
        
            * how the output behaves when it is modulated 
        
            ****************************************************************************/ 
        
           STDMETHODIMP CController::get_ModOutputType(int output, int no, int* pVal) 
        
           { 
        
           	if (output != VP_OUT_SOLENOID) 
        
           		return S_FALSE; 
        
           	*pVal = vp_getModOutputType(output, no); 
        
           	return S_OK; 
        
           } 
        
           STDMETHODIMP CController::put_ModOutputType(int output, int no, int newVal) 
        
           { 
        
           	if (output != VP_OUT_SOLENOID) 
        
           		return S_FALSE; 
        
           	vp_setModOutputType(output, no, newVal); 
        
           	return S_OK; 
        
           }

francisdb · 2024-02-06T20:04:51Z

Can you reproduce the issue on mac? Haven't tried that yet.

toxieainc · 2024-02-07T09:26:28Z

I think that we still have some issues/regressions here and there with 10.8.1, compared to 10.8.0, so maybe this is related??

toxieainc · 2024-02-07T09:27:51Z

@vbousquet Any idea maybe??

francisdb · 2024-02-07T10:20:36Z

Made some progress as to find the cause of the issue

Commenting out Controller.ChangedLamps in the LampTimer_Timer solves the flipper issue. (with of course lamps no longer working).

francisdb · 2024-02-07T10:48:40Z

Should I move this over to a new issue?

mazjohn · 2024-02-20T16:30:37Z

WOF -Table lighting/ lamps do not work or flash at all in vpinmame latest builds. Flippers erratic/get stuck - cannot isolate. Tested with 10.73 x86 final and 10.8 rc1 with same results...intermittant script errors:
Runtime error

Line: 593
Subscript out of range: 'chgLamp(...)'

Edit/ Update: reverted back to build 720 dated DEC31 release and the issues are gone. I'm not a programmer- So dumb question: will all table scripts that do not get updated be broken moving forwards or will this below fix make its way into a future build to ensure backwards compatibility? respect// thank you for bringing these amazing works to this hobby.

francisdb · 2024-02-20T17:25:45Z

That specific issue is fixed by changing the array declarations from capacity 400 to 610 in the script.

See jsm174/vpx-standalone-scripts#251

toxieainc · 2024-02-24T05:43:19Z

Flipper issues could be fixed now, please test @francisdb

toxieainc · 2024-02-24T06:07:32Z

Doesn't work for me yet, so far, so reopening. @vbousquet for vis

francisdb · 2024-02-24T06:38:51Z

Probably stupid question: what do you mean with "for vis"?

toxieainc · 2024-02-24T07:57:37Z

I'm never 100% sure if Vince gets the PinMAME issue mails, so pinging him explicitly for stuff that is related to his changes.

vbousquet · 2024-02-24T08:54:00Z

I keep an eye on Github only (I also have a look from time to time to discord / VPF but the feedback is usually too largely spread and not enough cleanly reported to be usable) but I miss things. There are just too much. So no problem.

Regarding the SAM emulation issues. I have just pushed a new PR for these bugs which improves flipper emulation (lower latency, hack designed around IJ4 emulation bug only). The original implementation also used some nasty hacks to keep things running so it is a bit difficult to identify what should be removed since some hacks were only needed due to the lack of PWM support, other are needed due to emulation issue (like IJ4).

For WOF, I was not able to reproduce the issue (on the latest with teh latest fix), so I would need some more hints to have a look.

francisdb · 2024-02-24T09:39:50Z

I'm never 100% sure if Vince gets the PinMAME issue mails, so pinging him explicitly for stuff that is related to his changes.

Got that part but I suppose that's some kind of abbreviation?

toxieainc · 2024-02-24T09:46:08Z

Simpler.. _vis_ibility

toxieainc · 2024-02-24T15:10:05Z

WOF flippers now seem to consistently work with the latest commit 544085b, @francisdb please also verify

francisdb · 2024-02-24T19:37:39Z

Issue still there for me with latest pinmame on standalone linux 10.8.1 and 7b0aafb
Still fixes itself by commenting out Controller.ChangedLamps

    ' chgLamp = Controller.ChangedLamps
    ' If Not IsEmpty(chgLamp) Then
    '     For ii = 0 To UBound(chgLamp)
    '         LampState(chgLamp(ii, 0) ) = chgLamp(ii, 1)       'keep the real state in an array
    '         FadingLevel(chgLamp(ii, 0) ) = chgLamp(ii, 1) + 4 'actual fading step
    '     Next
    ' End If

francisdb · 2024-02-26T06:26:12Z

@toxieainc why can't I reopen this issue?

toxieainc · 2024-02-26T07:00:40Z

No clue, reopening

vbousquet · 2024-03-09T08:07:23Z

This is the latest issue (beside improving filtering) following the PWM changes but I still can't reproduce it.
Reading from the above, I'm not sure:

if it happens on regular Window's version of VPX or if it only on standalone,
if it still there following the latest script changes inside VPX (and especially cleanups of SAM flipper code).

@francisdb could you confirm if the bug is still there for you ? If so, could you provide a link to the offending table (to check if it is maybe a table script bug) ?

francisdb · 2024-03-09T08:41:05Z

For now I can only reproduce it on standalone branch or 10.8.1 standalone, works fine on windows. And only for this table which is strange.

https://vpuniverse.com/files/file/5501-wheel-of-fortune-stern-2007/

With patched script from https://github.com/jsm174/vpx-standalone-scripts/tree/master/Wheel%20of%20Fortune%20(Stern%202007)%201.0 (increased array sizes)

Still have flippers not always reacting or being stuck in up position with latest 10.8.1 branch but happens less often than before.

Not calling Controller.ChangedLamps still fixes the issue or makes it much less likely to happen.

@jsm174 can you reproduce this one on mac/linux?

toxieainc · 2024-03-12T22:44:15Z

@francisdb Can you please test again with the latest build?

francisdb · 2024-03-13T07:26:08Z

Issue persists with b06d8d4
Do we have anybody else who can reproduce this issue?

embryodead · 2024-03-16T10:35:14Z

As previous user say lastest vpx 10.8 build on windows with the lastest vpinmame build from yesterday.
wpt, wof and also big buck hunter, no insert on playfield even with the fix in the script and flipper stuck on wof(flippers are fine in indy and wpt).

Fix vpinball#196

francisdb · 2024-03-17T16:00:58Z

Confirming this is fixed. Thanks @vbousquet !

Fix vpinball#196

francisdb closed this as completed Jan 19, 2024

francisdb reopened this Feb 6, 2024

toxieainc changed the title ~~Lamps above 400 on Wheel of Fortune~~ Flipper issues on WOF (was: Lamps above 400 on Wheel of Fortune) Feb 7, 2024

toxieainc added the regression label Feb 7, 2024

toxieainc mentioned this issue Feb 9, 2024

ij4_210 erratic flipper behavior #219

Closed

toxieainc closed this as completed Feb 24, 2024

toxieainc reopened this Feb 24, 2024

toxieainc closed this as completed Feb 24, 2024

toxieainc reopened this Feb 26, 2024

francisdb mentioned this issue Mar 11, 2024

WOF crashes on boot / GNR no flashers & others same... #247

Closed

vbousquet added a commit to vbousquet/pinmame that referenced this issue Mar 16, 2024

Fix WOF overlay between lamps & solenoids

d9d6e28

Fix vpinball#196

vbousquet mentioned this issue Mar 16, 2024

Fix WOF overlay between lamps & solenoids #255

Merged

toxieainc closed this as completed in #255 Mar 17, 2024

francisdb mentioned this issue Mar 25, 2024

Flippers intermittent lock up or don’t respond #262

Open

francisdb pushed a commit to francisdb/pinmame that referenced this issue Oct 21, 2024

Fix WOF overlay between lamps & solenoids

4040adf

Fix vpinball#196

Flipper issues on WOF (was: Lamps above 400 on Wheel of Fortune) #196

Flipper issues on WOF (was: Lamps above 400 on Wheel of Fortune) #196

Comments

francisdb commented Jan 18, 2024

vbousquet commented Jan 19, 2024

francisdb commented Jan 19, 2024 • edited Loading

toxieainc commented Jan 20, 2024

toxieainc commented Jan 29, 2024

francisdb commented Feb 6, 2024

toxieainc commented Feb 6, 2024

francisdb commented Feb 6, 2024

jsm174 commented Feb 6, 2024

francisdb commented Feb 6, 2024

francisdb commented Feb 6, 2024

jsm174 commented Feb 6, 2024 • edited Loading

francisdb commented Feb 6, 2024

toxieainc commented Feb 7, 2024

toxieainc commented Feb 7, 2024

francisdb commented Feb 7, 2024 • edited Loading

francisdb commented Feb 7, 2024

mazjohn commented Feb 20, 2024 • edited Loading

WOF -Table lighting/ lamps do not work or flash at all in vpinmame latest builds. Flippers erratic/get stuck - cannot isolate. Tested with 10.73 x86 final and 10.8 rc1 with same results...intermittant script errors: Runtime error

francisdb commented Feb 20, 2024 • edited Loading

toxieainc commented Feb 24, 2024

toxieainc commented Feb 24, 2024

francisdb commented Feb 24, 2024

toxieainc commented Feb 24, 2024

vbousquet commented Feb 24, 2024

francisdb commented Feb 24, 2024

toxieainc commented Feb 24, 2024

toxieainc commented Feb 24, 2024

francisdb commented Feb 24, 2024 • edited Loading

francisdb commented Feb 26, 2024

toxieainc commented Feb 26, 2024

vbousquet commented Mar 9, 2024

francisdb commented Mar 9, 2024

toxieainc commented Mar 12, 2024

francisdb commented Mar 13, 2024

embryodead commented Mar 16, 2024

francisdb commented Mar 17, 2024

francisdb commented Jan 19, 2024 •

edited

Loading

jsm174 commented Feb 6, 2024 •

edited

Loading

francisdb commented Feb 7, 2024 •

edited

Loading

mazjohn commented Feb 20, 2024 •

edited

Loading

WOF -Table lighting/ lamps do not work or flash at all in vpinmame latest builds. Flippers erratic/get stuck - cannot isolate. Tested with 10.73 x86 final and 10.8 rc1 with same results...intermittant script errors:
Runtime error

francisdb commented Feb 20, 2024 •

edited

Loading

francisdb commented Feb 24, 2024 •

edited

Loading