-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix rubocop removing trailing commas from multi-line declarations #86
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportBase: 1.63% // Head: 1.63% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #86 +/- ##
======================================
Coverage 1.63% 1.63%
======================================
Files 2 2
Lines 61 61
======================================
Hits 1 1
Misses 60 60
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
fe2563f
to
90386a8
Compare
Rebased after the merge of #85. |
90386a8
to
2075929
Compare
2075929
to
43eb0cb
Compare
rubocop in this repo is now successfully eating its own dog food... |
before we merge this I think ot makes sense to have an overview of the impact. I am afraid we need to update all modules after this change is released |
Ya. I've been thinking about how to incorporate rubocop into modulesync. I'm also thinking that we should be pinning the version in modules in order to prevent a massive simultaneous update in the future. |
I'm strongly in favor of this, but it will cause changes in most modules so I'd suggest it's a major version bump. We do plan one anyway for dropping Ruby < 2.7, so perhaps we should align those. |
I'm wondering if the right approach is to do a module sync that adds a branch name to every pupmod that pins the file to the way it is now. Then we can merge this PR and an related PR to modulesync_config that bumps the branch ref. That will put off needing to modify individual mods until the next modsync run. |
We aim to make the module also usable outside of Vox Pupuli, so we can't control it. It must be a major version IMHO. |
No description provided.