Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rubocop: Naming/MethodParameterName: Add common short parameters names to AllowedNames #71

Merged
merged 1 commit into from
Mar 12, 2022

Conversation

root-expert
Copy link
Member

Example:

def insync?(is)

That is parameter is all over the place in our modules.

@root-expert root-expert requested a review from alexjfisher March 11, 2022 12:22
@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #71 (13b9813) into master (8973588) will not change coverage.
The diff coverage is n/a.

❗ Current head 13b9813 differs from pull request most recent head 7f7e48b. Consider uploading reports for the commit 7f7e48b to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #71   +/-   ##
=======================================
  Coverage   27.86%   27.86%           
=======================================
  Files           2        2           
  Lines          61       61           
=======================================
  Hits           17       17           
  Misses         44       44           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8973588...7f7e48b. Read the comment docs.

rubocop.yml Outdated Show resolved Hide resolved
@root-expert root-expert changed the title rubocop: Change MinNameLength for Naming/MethodParameterName to 2 rubocop: Naming/MethodParameterName: Add common short parameters names to AllowedNames Mar 12, 2022
@bastelfreak bastelfreak added the enhancement New feature or request label Mar 12, 2022
@bastelfreak bastelfreak merged commit 4aacac7 into master Mar 12, 2022
@bastelfreak bastelfreak deleted the namingpar branch March 12, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants