Rubocop: Disable ImplicitSubject

[bastelfreak]

Enabling this cop causes a lot of noise in our project, because ruboop
would want us to reformat most of the tests.

Explanation of the cop:
https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ImplicitSubject

[codecov]

Codecov Report

Merging #68 (345fc0a) into master (89dd6c4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #68   +/-   ##
=======================================
  Coverage   27.86%   27.86%           
=======================================
  Files           2        2           
  Lines          61       61           
=======================================
  Hits           17       17           
  Misses         44       44           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89dd6c4...345fc0a. Read the comment docs.

[bastelfreak]

I have a high amount of open modulesync PRs and this change has a huge effect on them. I will hold of with the modulsync PRs until we decided to disable/enable this Cop.

[bastelfreak]

I think we could set EnforcedStyle: single_statement_only as well.

let's take a look at:

it { is_expected.to contain_file('/etc/all-knowing-dns.conf').with_content(%r{listen #{params_set[:listen][0]}}) }

if the cop is disabled or set to one of the enforced styles, it stays the same. I think we use this style in 90% of the tests.

let's take a look at this:

  it {
    is_expected.to contain_service('all-knowing-dns').with(
      ensure: 'running',
      enable: true,
      hasstatus: true,
      hasrestart: true,
      require: 'Package[all-knowing-dns]'
    )
  }

with the style set to disabled or to single_statement_only, it stays the same. If we set it to single_line_only it will be converted to:

  it {
    expect(subject).to contain_service('all-knowing-dns').with(
      ensure: 'running',
      enable: true,
      hasstatus: true,
      hasrestart: true,
      require: 'Package[all-knowing-dns]'
    )
  }

That's why I think EnforcedStyle: single_statement_only would be fine as well.

[ekohl]

single_statement_only would probably still trigger on:

it do
  is_expected.to contain_bla()
  is_expected.to contain_other_bla()
end

I'm fine with disabling this since I'm not sure it really adds much for us. We're not Ruby developers and only use rspec to test Puppet.