Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 3.0.0 #57

Merged
merged 1 commit into from
Oct 2, 2021
Merged

Release 3.0.0 #57

merged 1 commit into from
Oct 2, 2021

Conversation

bastelfreak
Copy link
Member

No description provided.

@bastelfreak bastelfreak self-assigned this Sep 17, 2021
@bastelfreak bastelfreak requested a review from ekohl September 17, 2021 08:56
@codecov
Copy link

codecov bot commented Sep 17, 2021 •
edited
Loading

Codecov Report

Merging #57 (7097572) into master (d5301a5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #57   +/-   ##
=======================================
  Coverage   28.33%   28.33%           
=======================================
  Files           2        2           
  Lines          60       60           
=======================================
  Hits           17       17           
  Misses         43       43

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5301a5...7097572. Read the comment docs.

ekohl
ekohl reviewed Sep 17, 2021
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it should be a major version instead. There's a reason we made the lint pack a major one. Merging this would mean a lot of our modules might start to fail.

@bastelfreak
Copy link
Member Author

yes, I think 3.0.0 makes more sense, since this gem isn't exclusivly used by Vox Pupuli.

@bastelfreak bastelfreak changed the title Release 2.7.0 Release 3.0.0 Oct 2, 2021
@bastelfreak bastelfreak mentioned this pull request Oct 2, 2021
Merged
@bastelfreak bastelfreak merged commit cfe8c99 into voxpupuli:master Oct 2, 2021
@bastelfreak bastelfreak deleted the rel270 branch October 2, 2021 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl left review comments

@bjoernhaeuser bjoernhaeuser bjoernhaeuser approved these changes

Assignees

@bastelfreak bastelfreak

Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bastelfreak @ekohl @bjoernhaeuser